Map floats over the footer while scrolling! - UI Bug

[wajeehamushtaq]

Fixes #10306
I try to fix the Map floats over the footer while scrolling! - UI Bug (1/3). The problem arise due to leaflet map styling. The position is set to absolute so this will create the problem.

Sorry for the unclear pictures.

[gitpod-io]

[jywarren]

Hi! I believe this is an error unrelated to your code - due to #10341 and my fault! I'm restarting the test to try to get past it.

Warning: NING] Unrecognized arguments: google_project, google_json_key_location
Progress: |================================================ FAIL TagTest#test_contributors_with_timeframe (7.57s)
        Expected: [1, 2]
          Actual: [1, 2, 5, 6, 12]

[jywarren]

Yay looks like this worked well!

[jywarren]

Oh hi @wajeehamushtaq it looks like changes from #10336 made it into this PR too. If both check out, we can just ignore and merge both. But in the future this may come up in relation to working from your main branch, so all your changes get mixed together. Instead, each time you work on a new PR, try branching off a new branch name from main so that they are all separate divergences from the main branch. Then you can keep updating your local main branch from publiclab/plots2 main branch, and keep working off a recent copy of that. Does that make sense?

For future PRs you may need to do 'git pull -f https://github.com/publiclab/plots2.git mainto overwrite your local main branch so that you have an updated copy to work from. Just be sure you don't overwrite changes you want to be using! You can first save them by runninggit branch myFeatureBranchName` (using your own custom name) and they'll be saved in their own branch. Happy to help with more Git stuff too! There's a nice guide on this workflow here: https://guides.github.com/introduction/flow/

[wajeehamushtaq]

Thank you @jywarren , I got my mistake. I will fix it

[codeclimate]

Code Climate has analyzed commit 7081b00 and detected 0 issues on this pull request.

View more on Code Climate.