Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asset not present deprecation warning #5126

Closed
4 tasks
cesswairimu opened this issue Mar 17, 2019 · 2 comments · Fixed by #5159
Closed
4 tasks

Remove asset not present deprecation warning #5126

cesswairimu opened this issue Mar 17, 2019 · 2 comments · Fixed by #5159
Labels
assigned first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@cesswairimu
Copy link
Collaborator

Main issue #4624
created specifically for @Julius26

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

Problem:
This asset pipeline deprecation warning

DEPRECATION WARNING: The asset "dynamic_search.js" is not present in the asset pipeline.Falling back to an asset that may be in the public folder.                                                     
This behavior is deprecated and will be removed.

📝 Update:
We are including a javascript file that was removed/ was never there.
Lets remove this line
https://github.com/publiclab/plots2/blob/master/app/views/admin/assets.html.erb#L8

After changing run the tests and make sure the deprecation warning is gone.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

@cesswairimu cesswairimu added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. assigned labels Mar 17, 2019
@An0u
Copy link

An0u commented Mar 18, 2019

Has anyone opened a pull request on this and is working on it already?

@An0u An0u mentioned this issue Mar 18, 2019
5 tasks
@cesswairimu
Copy link
Collaborator Author

Hey @An0u this one @Julius26 is working on it.If you are looking for an fto leave a comment here #4963 and we will get an issue for you soon

@cesswairimu cesswairimu changed the title Remove asset not pressent deprecation warning Remove asset not present deprecation warning Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants