Change navbar links to icons #3328
Comments
|
Hi @gauravano can you please break this into 2 different issues. So that two people can work on it. |
|
Hi @SidharthBansal, I think it's fine as it is, as the issue just need replacing links with icons at some places, its already an easy task 😅 . What do you say? |
|
Ok |
|
Published on GCI dashboard |
|
An icon in addition to text will be awesome. What do you say? |
|
Yes and we can make this a multi-use issue to go to https://fontawesome.com/v4.7.0/ and find an icon, and paste it in here with a link and a screenshot to suggest one for each item. +1! |
|
Yes and we can make this a multi-use issue to go to
https://fontawesome.com/v4.7.0/ and find an icon, and paste it in here with
a link and a screenshot to suggest one for each item. +1!
…On Mon, Oct 22, 2018 at 11:42 AM Sidharth Bansal ***@***.***> wrote:
An icon in addition to text will be awesome. What do you say?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#3328 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ1mQCXhlgTN24_kja4nF8W8DVet4ks5unedVgaJpZM4WpnT4>
.
|
|
Hi, I'm working on solving this issue for codein! How is this for the user icon: Respective links: I think I've made the neccessary changes in the file but can't view it as I'm having trouble running Phusion Passenger. I've followed the standard installation for plots2 until step 9, when I get the following error: |
|
Cool! these look great. Can you check out
#3840 and post your install
issues there so we can help folks on those in one place? thank you!
However, I believe just the icons completes a GCI task. Adding them to the
code might be a further task!
…On Sun, Oct 28, 2018 at 8:18 PM Jonathan Xu ***@***.***> wrote:
Hi, I'm working on solving this issue for codein!
How is this for the user icon:
[image: image]
<https://user-images.githubusercontent.com/22998430/47620705-9ea6a780-dac3-11e8-89b9-03fc7873a1b2.png>
And for the dashboard icon:
[image: image]
<https://user-images.githubusercontent.com/22998430/47620709-b2520e00-dac3-11e8-9087-55a440dba73f.png>
Respective links:
https://fontawesome.com/v4.7.0/icon/user
https://fontawesome.com/v4.7.0/icon/home
I think I've made the neccessary changes in the file but can't view it as
I'm having trouble running Phusion Passenger. I've followed the standard
installation for plots2 until step 9, when I get the following error:
https://pastebin.com/AaeeizLL
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#3328 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ0cSQT4QeqvmUGGYgU22oxGkRe02ks5upkk5gaJpZM4WpnT4>
.
|
|
@JonathanXu1 have you worked on this? Where is the pr? |
|
Yeah I worked on it a long time ago but the task expired before I could claim it |
|
OK, so did you submitted any PR?
Was there any review issue or were you late?
…On Sun, Dec 9, 2018, 7:33 PM Jonathan Xu ***@***.*** wrote:
Yeah I worked on it a long time ago but the task expired before I could
claim it
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3328 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUACQ_8-21KIkAhS_8biBYe5h9-BPjVaks5u3RghgaJpZM4WpnT4>
.
|
|
I will give you reward for your work. |
|
https://codein.withgoogle.com/dashboard/tasks/5446379464818688/ |
|
Thank you :) |
We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.
To make the Navbar more compact replace the following navbar links:
profilelink with the icon of the personDashboardlink with the house iconHint: You need to make changes in this https://github.com/publiclab/plots2/blob/master/app/views/layouts/_header.html.erb file
Mention @publiclab/community-reps after solving as getting their consent is essential for choosing icon and for finalizing the view too. Feel free to ask for help, if required. Thanks!
The text was updated successfully, but these errors were encountered: