Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bbox() function's ActiveRecord query to new Rails syntax #403 #426

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

labseven
Copy link
Contributor

@labseven labseven commented Mar 21, 2019

References #403

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- in travis rake test
  • code has been rebased on top of latest master (check if another pull request was added recently, and please rebase)
  • pull request is descriptively named and, if possible, multiple commits squashed if they're smaller changes

I installed the application locally, but rake test is failing on a gdal2tiles.py command (see here).

@welcome
Copy link

welcome bot commented Mar 21, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@jywarren
Copy link
Member

Hello, thank you! I saw the GDAL error you mentioned and believe it's a version issue; note that it's passing on Travis tests here, so I think we're fine. Thanks for the suggestion about installing gdal; we'll have to figure out how to do that with the right version. I'm merging this it looks great, thanks a lot!!! 👍 🎉

Will you be applying for the fellowship position? Thanks!

@jywarren jywarren merged commit 0bf18f5 into publiclab:main Mar 21, 2019
@welcome
Copy link

welcome bot commented Mar 21, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@labseven
Copy link
Contributor Author

@jywarren Thank you for accepting my pull request.
I just submitted my application for the fellowship!

@jywarren
Copy link
Member

jywarren commented Mar 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants