Edge Detect Fixed!

[harshkhandeparkar]

Fixes #1576 (<=== Replace 0000 with the Issue Number)

This was the simplest fix. Just had to change a global variable to a local one.

New Output:

Now it doesn't make a difference if the image is loaded first and then edge-detect is added or the other way around.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[harshkhandeparkar]

@jywarren @publiclab/is-reviewers

[harshkhandeparkar]

The solution was a single line change but it took me 2 hrs to figure it out!
Also, why is Travis failing?

[harshkhandeparkar]

Ok found that error too. Fixing it soon.
It seems Edge Detect was broken for GIFs earlier. Just compare these outputs.

OLD:

NEW:

[harshkhandeparkar]

Fixed that too.

[harshkhandeparkar]

The tests had passed locally 😕

[harshkhandeparkar]

I don't think the error was caused by my changes. Also, it is only failing for node 8.

[rishabhshuklax]

@harshkhandeparkar try restarting the build once again

[rishabhshuklax]

Amazing! 🎉

[harshkhandeparkar]

I'll try that. Thanks.

…

On Tue, 18 Feb, 2020, 10:21 PM Rishabh Shukla, ***@***.***> wrote: ***@***.**** approved this pull request. Amazing! 🎉 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1629?email_source=notifications&email_token=AIJI5HZVFULTO6NOJQ2QYL3RDQG2RA5CNFSM4KVZY3FKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCV6NYCA#pullrequestreview-360504328>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJI5H7NUMIRC72J7XQFLUTRDQG2RANCNFSM4KVZY3FA> .

[codecov]

Codecov Report

Merging #1629 into main will increase coverage by 10.29%.
The diff coverage is 63.90%.

@@             Coverage Diff             @@
##             main    #1629       +/-   ##
===========================================
+ Coverage   55.11%   65.41%   +10.29%     
===========================================
  Files         117      132       +15     
  Lines        2344     2741      +397     
  Branches      360      438       +78     
===========================================
+ Hits         1292     1793      +501     
+ Misses       1052      948      -104     

Impacted Files	Coverage Δ
examples/lib/scopeQuery.js	18.51% <ø> (ø)
src/Modules.js	100.00% <ø> (ø)
src/modules/WebglDistort/Module.js	2.29% <0.00%> (ø)
src/ui/SetInputStep.js	12.90% <0.00%> (-1.39%)	⬇️
src/modules/ColorHalftone/Module.js	3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js	11.35% <4.08%> (-0.85%)	⬇️
examples/lib/intermediateHtmlStepUi.js	11.11% <5.55%> (+0.94%)	⬆️
examples/lib/insertPreview.js	13.15% <20.00%> (-0.36%)	⬇️
src/util/getImageDimensions.js	20.00% <20.00%> (ø)
src/util/isGif.js	20.00% <20.00%> (ø)
... and 100 more

[harshkhandeparkar]

Passed!

[gitpod-io]

[jywarren]

This looks great, and was easy to test out in GitPod! https://gitpod.io/#https://github.com/publiclab/image-sequencer/pull/1629

Confirmed! Thank you!!!

[harshkhandeparkar]

Ty!