-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Test modules for GIF's #1530
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1530 +/- ##
=======================================
Coverage 66.61% 66.61%
=======================================
Files 130 130
Lines 2672 2672
Branches 430 430
=======================================
Hits 1780 1780
Misses 892 892
|
Hmm, tests didn't pass on one of these but it needed updating again anyways... let's see what happens! |
Draw-Rectangle Module which didn't passed, will get passed once #1535 PR got merged... |
Looks like it passed after all, is this then ready for a merge? Thank you! |
Let's Go!! |
@root00198 I see tests failing in the logs |
Yes they were passing. My one module draw-rectangle was failing but it was not because of the code in this PR. It was because of the reason in #1535. |
Hm. My update didn't seem to help. I think this may need a true rebase? |
The tests won't pass until #1535 gets merged! |
Updating branch! Let's see. |
Awesome. Great work!!! |
Thank you!!!! |
Fixes #1479
I am creating this PR again, because the #1490 PR created some serious conflicts.
@harshkhandeparkar @jywarren, please review it..
There are some issue that I tried to address in the previous PR, like the histogram module issue. I will create a seperate PR for that.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!