Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public lab dependency chart #424

Merged
merged 13 commits into from
Feb 27, 2021
Merged

Public lab dependency chart #424

merged 13 commits into from
Feb 27, 2021

Conversation

YogeshSharma01
Copy link
Contributor

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@YogeshSharma01 YogeshSharma01 mentioned this pull request Feb 3, 2021
Closed
jywarren
jywarren approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!!!! Thank you so much!!!

jywarren
jywarren reviewed Feb 4, 2021
View reviewed changes
index.html Outdated
@@ -320,6 +320,12 @@ <h2 class="contributors-head" id="contributer">Contributors</h2>
<div class="well contributors"><div id="spinner-icon" style="text-align: center;"><i class="fa fa-spinner fa-spin"></i></div><p class="usernames"></p><hr /><p class="avatars text-center"></p></div>
</div>

<!-- Dependency chart -->
<div id="dependency-div">
<img class="dependency-chart" src="./images/chart.png" alt="dependency-chart">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, is the chart already in our repository, or do we need to add that file too? Thank you!!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @jywarren I have added that file too.
Warm Regards,
Yogesh Sharma
Thanks

@YogeshSharma01 YogeshSharma01 force-pushed the Public-lab-dependency-chart branch from 7f1ba6f to f8da69f Compare February 4, 2021 16:41
@harshkhandeparkar
Copy link
Member

Can you provide a screenshot or a GIF of the browser window resizing or dev tools responsiveness test?

@YogeshSharma01 YogeshSharma01 force-pushed the Public-lab-dependency-chart branch from b99829e to 65f8b4b Compare February 4, 2021 17:49
@YogeshSharma01
Copy link
Contributor Author

Yeah sure @harshkhandeparkar

Chart.mov

@daemon1024
Copy link
Member

I think width:100%; would streamline all the contents across site since it looks a bit awkward. It is a bit subjective to let me know what y'all think.

@daemon1024
Copy link
Member

daemon1024 commented Feb 4, 2021 •
edited
Loading

Also I believe .png files are pretty heavy on sites, If we would have a higher quality png, we may convert it to webp and this would not impact the website performance negatively.

@YogeshSharma01 YogeshSharma01 force-pushed the Public-lab-dependency-chart branch from b849f4c to 1054d9e Compare February 8, 2021 10:46
@YogeshSharma01
Copy link
Contributor Author

Hi, @daemon1024 apologize for my late reply actually I was busy with my exams. Yes agreed with your point width of the picture should be 100% and I also convert the picture from .png to .webp.
Thanks

@daemon1024
Copy link
Member

daemon1024 commented Feb 8, 2021 •
edited
Loading

No problem @YogeshSharma01. I believe you will need convert the image file first. Just changing the extension won't help 😅. Also can you let me know the source of the file.
While you are at it, it would be great if you could look at the your first comment and mention the issue number and other details there :)
Thank You ☺️

@YogeshSharma01 YogeshSharma01 force-pushed the Public-lab-dependency-chart branch from de40bea to 9627497 Compare February 20, 2021 08:03
@YogeshSharma01
Copy link
Contributor Author

Hi, @daemon1024 sorry for the late reply actually I was busy with my exams and now I have converted the image file.
review it.
Warm Regards
Yogesh Sharma
Thanks

daemon1024
daemon1024 suggested changes Feb 21, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
@YogeshSharma01 YogeshSharma01 force-pushed the Public-lab-dependency-chart branch from ac7195c to 552558f Compare February 21, 2021 11:10
daemon1024
daemon1024 suggested changes Feb 26, 2021
View reviewed changes
Copy link
Member

@daemon1024 daemon1024 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the webp file to dependency chart and remove png file from the commit. Thank You
Screenshot_2021-02-26-17-10-53-78

@YogeshSharma01
image file renamed and removed
5d3b38d 
removed png file from the commit and renamed the webp file to dependency chart
@YogeshSharma01 YogeshSharma01 force-pushed the Public-lab-dependency-chart branch from b1b8f23 to 5d3b38d Compare February 27, 2021 06:12
jywarren
jywarren approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!!! Thank you!!!

@jywarren jywarren merged commit 0165b1b into publiclab:main Feb 27, 2021
@jywarren
Copy link
Member

Great work!!!!

@willow19 willow19 mentioned this pull request Apr 22, 2021
Open
7 tasks
TildaDares pushed a commit to TildaDares/community-toolbox that referenced this pull request Apr 28, 2021
@YogeshSharma01 @TildaDares
Public lab dependency chart (publiclab#424)
9b6bcf3 
* New Navbar added with the logo of PublicLab

* Changes in Navbar

* Set the size of The Logo-Image in Navbar section

* fix the navbar in dark mode

* Public dependency chart added at the bottom of the page

* Public dependency chart added at the bottom of the page

* Chart added

* Chart added

* set the dependency chart width

* convert the dependency chart .png to webp

* set the filename

* image file renamed and removed
removed png file from the commit and renamed the webp file to dependency chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daemon1024 daemon1024 daemon1024 approved these changes

@harshkhandeparkar harshkhandeparkar harshkhandeparkar approved these changes

@jywarren jywarren jywarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YogeshSharma01 @harshkhandeparkar @daemon1024 @jywarren