Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author thumbnail to issue display #109

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

professionalzack
Copy link

@professionalzack professionalzack commented Dec 11, 2018

Fixes #108

I am not exactly sure what all those other 'changes' are, since all i did was add one line of code ( line 82235 of dist/community-toolbox.js ), and honestly from what i can tell, the other 'changes' dont actually look different at all from the original. could be the npm install ? idk.

anyways I added the author thumbnails as per the issue #108 . I used style classes from bootstrap 3.2, as that seems to be what is being used for these files. i am happy to update my single line of code whenever/if ever this gets changed. cheers !

now to try the tests

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #108 -style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented Dec 11, 2018

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@professionalzack
Copy link
Author

@jywarren is this the sort of thing you were looking for?
i am attempting to include a demo below to match your mock-up on the issue page
thumbnail-demo

@jywarren
Copy link
Member

jywarren commented Dec 11, 2018 via email

@@ -82232,6 +82232,7 @@ function insertIssue(issue, el) {
body += "<a class='label label-default' href='" + label.url + "' style='background:#" + label.color + ";'>" + label.name + "</a> ";
});
body += "</div>";
body += "<img width='50px' src='" + issue.user.avatar_url + "' class='img-circle'> &emsp;";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok so this actually needs to go in the src directory, in the corresponding file there, but then when you run "grunt build" itll get compiled into the dist folder. Does that make sense? Thank you!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. I cut the line from dist/community-toolbox and added it to src/ui.js instead. Then I ran grunt build and it showed up in dist/community-toolbox. commit should be available below.

@Rishabh570
Copy link
Collaborator

@professionalzack Oh great!! Can you share the screenshot of your most recent changes...?
Thanks for your contribution :)

@professionalzack
Copy link
Author

@Rishabh570 sorry, what is it that you want a screenshot of? the git comparison? my visual studio code file ?

@professionalzack
Copy link
Author

maybe this ??

screen shot 2018-12-11 at 10 24 25 am

@Rishabh570
Copy link
Collaborator

@professionalzack This looks great!

@Rishabh570
Copy link
Collaborator

@jywarren I guess it is ready to merge...

@Rishabh570
Copy link
Collaborator

@jywarren Please take a look here :)

@grvsachdeva
Copy link
Member

Hi @jywarren, your review is required here. Thanks!

@grvsachdeva grvsachdeva changed the title Issue 108 author thumbnail Add author thumbnail to issue display Jan 8, 2019
@jywarren
Copy link
Member

jywarren commented Jan 8, 2019

This looks really great. Just needs a rebase and we should be good to merge!

@Rishabh570
Copy link
Collaborator

Hi @professionalzack, this is really cool. Can you please remove the conflicts, it is good to go then 😃

@grvsachdeva
Copy link
Member

Hey @Rishabh570, as the @professionalzack is not responding, can you push this to completion? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add author thumbnail to issue display
4 participants