-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add author thumbnail to issue display #109
base: main
Are you sure you want to change the base?
Add author thumbnail to issue display #109
Conversation
Thanks for opening this pull request! |
@jywarren is this the sort of thing you were looking for? |
Wow awesome!!! This is fantastic. Thank you!
…On Mon, Dec 10, 2018, 10:24 PM professionalzack ***@***.*** wrote:
@jywarren <https://github.com/jywarren> is this the sort of thing you
were looking for?
i am attempting to include a demo below to match your mock-up on the issue
page
[image: thumbnail-demo]
<https://user-images.githubusercontent.com/26235535/49776470-ff272800-fcb0-11e8-8d0c-0851bca2cf1f.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#109 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ1A4V6AhlqRS8BAcRIQS8Z9q6UgRks5u3yU9gaJpZM4ZMl5k>
.
|
dist/community-toolbox.js
Outdated
@@ -82232,6 +82232,7 @@ function insertIssue(issue, el) { | |||
body += "<a class='label label-default' href='" + label.url + "' style='background:#" + label.color + ";'>" + label.name + "</a> "; | |||
}); | |||
body += "</div>"; | |||
body += "<img width='50px' src='" + issue.user.avatar_url + "' class='img-circle'>  "; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok so this actually needs to go in the src directory, in the corresponding file there, but then when you run "grunt build" itll get compiled into the dist folder. Does that make sense? Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. I cut the line from dist/community-toolbox
and added it to src/ui.js
instead. Then I ran grunt build
and it showed up in dist/community-toolbox
. commit should be available below.
@professionalzack Oh great!! Can you share the screenshot of your most recent changes...? |
@Rishabh570 sorry, what is it that you want a screenshot of? the git comparison? my visual studio code file ? |
@professionalzack This looks great! |
@jywarren I guess it is ready to merge... |
@jywarren Please take a look here :) |
Hi @jywarren, your review is required here. Thanks! |
This looks really great. Just needs a rebase and we should be good to merge! |
Hi @professionalzack, this is really cool. Can you please remove the conflicts, it is good to go then 😃 |
Hey @Rishabh570, as the @professionalzack is not responding, can you push this to completion? Thanks! |
Fixes #108
I am not exactly sure what all those other 'changes' are, since all i did was add one line of code ( line 82235 of dist/community-toolbox.js ), and honestly from what i can tell, the other 'changes' dont actually look different at all from the original. could be the
npm install
? idk.anyways I added the author thumbnails as per the issue #108 . I used style classes from bootstrap 3.2, as that seems to be what is being used for these files. i am happy to update my single line of code whenever/if ever this gets changed. cheers !
now to try the tests
rake test
fixes #108
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!