Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1332 Updated Document Tooltip Feature in README.md #1336

Merged
merged 4 commits into from
Jan 21, 2023

Conversation

sudeep162002
Copy link
Contributor

@sudeep162002 sudeep162002 commented Jan 20, 2023

Fixes #1332

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [✔️ ] PR is descriptively titled 📑 and links the original issue above 🔗
  • [ ✔️] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • [ ✔️] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [ ✔️] screenshots/GIFs are attached 📎 in case of UI updates
  • [ ✔️] @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Jan 20, 2023

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@7malikk
Copy link
Collaborator

7malikk commented Jan 20, 2023

Hello @sudeep162002 Great job 🎉

Kindly add the number to the corresponding issue you solved to help the maintainers. Thank you!

I'm sure it'll get reviewed soon @cesswairimu @TildaDares

@sudeep162002 sudeep162002 changed the title Updated Document Tooltip Feature in README.md issue #1332 Updated Document Tooltip Feature in README.md Jan 20, 2023
@sudeep162002 sudeep162002 changed the title issue #1332 Updated Document Tooltip Feature in README.md Issue #1332 Updated Document Tooltip Feature in README.md Jan 20, 2023
@TildaDares
Copy link
Member

Hi @7malikk, feel feee to approve if you think everything looks good. You can either @cesswairimu or me to get it merged.

Thank you both!

@7malikk
Copy link
Collaborator

7malikk commented Jan 20, 2023

Hi @7malikk, feel feee to approve if you think everything looks good. You can either @cesswairimu or me to get it merged.

Thank you both!

Alright, @TildaDares Thank you!

README.md Outdated
@@ -77,7 +77,7 @@ map.whenReady(function() {
* [rotation](#rotation)
* [selected](#selected)
* [suppressToolbar](#Suppress-Toolbar)

* [tooltipText](#Tooltip-Text)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sudeep162002 Could you remove one space before the text
like so * [tooltipText](#Tooltip-Text) not * [tooltipText](#Tooltip-Text)
Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @sudeep162002

@7malikk 7malikk mentioned this pull request Jan 20, 2023
5 tasks
@7malikk
Copy link
Collaborator

7malikk commented Jan 20, 2023

@TildaDares, @cesswairimu I believe this is ready for a merge, thank you!

Great job @sudeep162002 🎉

@segun-codes
Copy link
Collaborator

@sudeep162002, great effort so far. One little change, please place the second code snippet in line 337 instead (and not 339). Issue #1332 is now updated to reflect this change, sorry for the mix-up.

issue2

@7malikk
Copy link
Collaborator

7malikk commented Jan 20, 2023

@sudeep162002, great effort so far. One little change, please place the second code snippet in line 337 instead (and not 339). Issue #1332 is now updated to reflect this change, sorry for the mix-up.

Thank you for catching that @segun-codes, must've been an oversight on my part.

@sudeep162002
Copy link
Contributor Author

changed the pr according to updated issue please review.

@segun-codes
Copy link
Collaborator

Hello @sudeep162002 Great job 🎉

Kindly add the number to the corresponding issue you solved to help the maintainers. Thank you!

I'm sure it'll get reviewed soon @cesswairimu @TildaDares

@sudeep162002, please, fix @7malikk's suggestion above (i.e., replace 0000 in Fixes #0000 (<=== Add issue number here) with the issue number of the issue this PR is related to).

@sudeep162002
Copy link
Contributor Author

done .

@segun-codes
Copy link
Collaborator

@7malikk, things look all set here, over back to you.

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @sudeep162002.

Thank you for the reviews @7malikk @segun-codes!

@TildaDares TildaDares merged commit edac0a9 into publiclab:main Jan 21, 2023
@welcome
Copy link

welcome bot commented Jan 21, 2023

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Tooltip Feature in README.md
4 participants