-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ImageUtil.js, Fixes Issue #1307 #1313
Conversation
Thanks for opening this pull request! |
Please review, @cesswairimu |
@owaisali8 this looks great, thanks! just a small feedback - I think using |
Done @sashadev-sky. |
Please review, @cesswairimu @sashadev-sky |
looks good! would you mind merging the latest changes from |
Latest changes from |
Change Keyword var to let in ImageUtil.js
Change Keyword let to const in src/util/ImageUtil.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, this is okay. I have also updated the issue to make the story straight. @cesswairimu, could you kindly merge.
@owaisali8, @sashadev-sky, many thanks!
Merging now, thanks all 🎉🎉🎉 |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thank you everyone for guiding me on how to contribute. |
Change Keyword var to let in src/util/ImageUtil.js
Fixes #1307
grunt test
Thanks!