Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImageUtil.js, Fixes Issue #1307 #1313

Merged
merged 4 commits into from
Dec 28, 2022
Merged

Conversation

owaisali8
Copy link
Contributor

@owaisali8 owaisali8 commented Dec 20, 2022

Change Keyword var to let in src/util/ImageUtil.js

Fixes #1307

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

Thanks!

@welcome
Copy link

welcome bot commented Dec 20, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@owaisali8
Copy link
Contributor Author

Please review, @cesswairimu

@sashadev-sky
Copy link
Member

@owaisali8 this looks great, thanks! just a small feedback - I think using const would be more appropriate than let in this scenario since we never change those values after we set them

@owaisali8
Copy link
Contributor Author

Done @sashadev-sky.

@owaisali8
Copy link
Contributor Author

Please review, @cesswairimu @sashadev-sky

@sashadev-sky
Copy link
Member

looks good! would you mind merging the latest changes from main before I approve? Let me know if you have any questions

@owaisali8
Copy link
Contributor Author

Latest changes from main has been merged

Change Keyword var to let in ImageUtil.js
Change Keyword let to const in src/util/ImageUtil.js
Copy link
Collaborator

@segun-codes segun-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, this is okay. I have also updated the issue to make the story straight. @cesswairimu, could you kindly merge.

@owaisali8, @sashadev-sky, many thanks!

@cesswairimu
Copy link
Collaborator

cesswairimu commented Dec 28, 2022

Merging now, thanks all 🎉🎉🎉
Nice to see you around @sashadev-sky 😊

@cesswairimu cesswairimu merged commit 008785c into publiclab:main Dec 28, 2022
@welcome
Copy link

welcome bot commented Dec 28, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@owaisali8
Copy link
Contributor Author

Thank you everyone for guiding me on how to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Keyword var to const in src/util/ImageUtil.js
4 participants