Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1311 - change let to const #1312

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Issue 1311 - change let to const #1312

merged 1 commit into from
Dec 23, 2022

Conversation

sandeshShahapur
Copy link
Contributor

@sandeshShahapur sandeshShahapur commented Dec 20, 2022 •
edited
Loading

Fixes #1311

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

@welcome
Copy link

welcome bot commented Dec 20, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@sandeshShahapur sandeshShahapur changed the title Issue 1311 change let to const Issue 1311 - change let to const Dec 20, 2022
@segun-codes
Copy link
Collaborator

segun-codes commented Dec 20, 2022 •
edited
Loading

Great effort @sandeshShahapur, many thanks!

@TildaDares, @cesswairimu you may now want to consider this PR for merging.

cesswairimu
cesswairimu approved these changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@cesswairimu cesswairimu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sandeshShahapur 🎉 , thanks for working on this

@sandeshShahapur @cesswairimu
Issue 1311 change var to const/let
2b362b5 
Fixes #1311   (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

- [x] PR is descriptively titled 📑 and links the original issue above 🔗
- [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
- [x] code is in uniquely-named feature branch and has no merge conflicts 📁
- [ ] screenshots/GIFs are attached 📎 in case of UI updates
- [ ] @mention the original creator of the issue in a comment below for help or for a review

> We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!
@cesswairimu
Copy link
Collaborator

Thanks a lot @segun-codes for the fto 💯

@cesswairimu cesswairimu merged commit 1087b94 into publiclab:main Dec 23, 2022
@welcome
Copy link

welcome bot commented Dec 23, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@7malikk
Copy link
Collaborator

7malikk commented Dec 23, 2022

Congratulations on your merge @sandeshShahapur 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesswairimu cesswairimu cesswairimu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Keyword let to const in src/mapmixins/BoxCollector.js
4 participants
@sandeshShahapur @segun-codes @cesswairimu @7malikk