Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace var keyword with let/const #1086

Closed
36 of 37 tasks
TildaDares opened this issue Oct 10, 2022 · 64 comments · Fixed by #1088, #1089, #1093, #1094 or #1096
Closed
36 of 37 tasks

Replace var keyword with let/const #1086

TildaDares opened this issue Oct 10, 2022 · 64 comments · Fixed by #1088, #1089, #1093, #1094 or #1096

Comments

@TildaDares
Copy link
Member

TildaDares commented Oct 10, 2022

Hi everyone, we'd like to update this project to use let/const instead of var. This task will be divided into several sub tasks and each one of you will get to work on one file. All you have to do is replace var with let/const where appropriate.

General rules

Use let when you know that the value of a variable will change.
Use const for every other variable.

If you'd like to know more about the differences between these keywords, you can read this freecodecamp article on var, let & const

Files to be Updated:

src/components

src/edit

src/edit/actions

src/edit/handles

src/edit/toolbar

src/mapmixins

src/util

src

@welcome
Copy link

welcome bot commented Oct 10, 2022

Thanks for opening your first issue here! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
You can make a gif too!
Do join our Gitter channel for some brainstorming discussions.

@leilayesufu
Copy link
Contributor

Hi @TildaDares
Thank you for assigning a FTO issue to me
I’d like to claim my issue and work on it

@ifeawoyemi
Copy link

I will do it

@ifeawoyemi
Copy link

I will take the Task @TildaDares

@Ibom99
Copy link
Contributor

Ibom99 commented Oct 10, 2022

Hello @TildaDares I claim my task and I’ll work on it! Thank you!✨

@leumasxxx
Copy link
Contributor

I claim this task @TildaDares

@mimi-tech
Copy link

Hello @TildaDares I calm this task

@Thesaleem
Copy link
Contributor

Hi @TildaDares Thanks! I’ll work on it now.

@TildaDares
Copy link
Member Author

Hi @mimi-tech, your name isn't included in this issue but rest assured we'll find something for you to work on. Thank you!

@Ranecodes
Copy link
Contributor

Hi @TildaDares. Will be working on the task assigned to me. Thanks!

@abd123codes
Copy link
Contributor

hi @TildaDares i would like to let you know i will be working on the issue assigned to me at "https://github.com/publiclab/Leaflet.DistortableImage/blob/main/src/edit/actions/ScaleAction.js"

@Tammy-Ajoko
Copy link
Contributor

Hi @TildaDares thank you for this I'm currently working on it

@Jennifer-tech
Copy link
Contributor

Thanks @TildaDares , I claim the task and I'm currently working on it

@titiodus
Copy link
Contributor

I accept my issue and will work on it @TildaDares

@Tammy-Ajoko
Copy link
Contributor

@TildaDares there a section for screenshot before making the final pull request. I'm not sure on how to link it or can I just go on and make the pull request without it

@OluwatuyiAbiola
Copy link
Contributor

HI @TildaDares I claim my issue

@TildaDares
Copy link
Member Author

Hi @Tammy-Ajoko, you can ignore that. Thank you!

@klaus139
Copy link
Contributor

Thanks for this @TildaDares I am working on this

@ChiomaNwosisi
Copy link
Contributor

Thank you @TildaDares i will work on this

@RealRichi3
Copy link
Contributor

Thanks @TildaDares I will work on this

@Tishly
Copy link

Tishly commented Oct 17, 2022

Hello @TildaDares. Please, I'd like to get assigned this issue to work on for my first contribution. Thank you.

@TildaDares
Copy link
Member Author

Hi @am-png, @Mootconn, @mimi-tech, @Achele, there are issues reserved for you here. Look at the list for the files reserved for you.

@am-ping
Copy link
Contributor

am-ping commented Oct 19, 2022

Thanks, I'll do it.

@Mootconn
Copy link

Ill claim this task please @TildaDares

@onireke
Copy link

onireke commented Oct 20, 2022

Hi @TildaDares please I am yet to be assigned a FTO the only I saw was that my comment was deleted. Kindly assist me. Thank you

@RoleyJes
Copy link

Hi @TildaDares please can I be assigned an issue? I'm an Outreachy applicant

TildaDares added a commit that referenced this issue Oct 20, 2022
Replaced var keywords with let or const - / src / edit / toolbars /DistortableImage.PopupBar.js #1086
@TildaDares TildaDares reopened this Oct 20, 2022
@TildaDares TildaDares reopened this Oct 20, 2022
@TildaDares
Copy link
Member Author

Hi @victorvictoria-maker, please look for the issue reserved for you in the issue description above. Thank you!

@TildaDares
Copy link
Member Author

TildaDares commented Oct 28, 2022

Hi @yukiyuli, please look for the issue reserved for you in the issue description above. Thank you!

@TildaDares TildaDares linked a pull request Nov 2, 2022 that will close this issue
5 tasks
vanithaak pushed a commit to vanithaak/Leaflet.DistortableImage that referenced this issue Nov 5, 2022
Replace var keyword with const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment