-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/globalfee): Ante handler fee decorator #775
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature/globalfee #775 +/- ##
=====================================================
+ Coverage 9.81% 10.01% +0.19%
=====================================================
Files 97 97
Lines 13880 14040 +160
=====================================================
+ Hits 1363 1406 +43
- Misses 12441 12557 +116
- Partials 76 77 +1
☔ View full report in Codecov by Sentry. |
0d27d30
to
44968fc
Compare
// Only check for minimum fees and global fee if the execution mode is CheckTx | ||
if !ctx.IsCheckTx() || simulate { | ||
return next(ctx, tx, simulate) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this validators can still propose 0fee txs right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, in case when the validator has configured minimum-gas-prices = "0ustars"
Added the ante handler to ensure enough fees have been set.
The fee calculation is based on gaia x/globalfee implementation
https://github.com/cosmos/gaia/blob/6fe097e3280baa360a28b59a29b8cca964a5ae97/x/globalfee/ante/fee.go
No tests. In separate PR 👉🏻 #786