Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move solver mod comment to resolver #319

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

Eh2406
Copy link
Member

@Eh2406 Eh2406 commented Jan 31, 2025

Fix #185, Part of #308

This useful piece of text was no longer part of our published docs, because it was module documentation on a private module.

src/lib.rs Outdated Show resolved Hide resolved
src/solver.rs Outdated Show resolved Hide resolved
@Eh2406 Eh2406 marked this pull request as ready for review February 5, 2025 19:31
//!
//! The first bound is the type of package names. It can be anything that implements our [Package] trait.
//! The [Package] trait is automatic if the type already implements
//! [Clone] + [Eq] + [Hash] + [Debug] + [Display](std::fmt::Display).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why's the Display link different than the others?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the others are in the prelude, and Display is not.

@Eh2406 Eh2406 added this pull request to the merge queue Feb 6, 2025
Merged via the queue into pubgrub-rs:dev with commit 00c688c Feb 6, 2025
7 checks passed
@Eh2406 Eh2406 deleted the missing-docs branch February 6, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of date documentation for Dev
2 participants