Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork maint #154

Closed
wants to merge 20 commits into from
Closed

fork maint #154

wants to merge 20 commits into from

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Nov 16, 2023

mpizenberg and others added 20 commits July 10, 2021 22:32
…-rs#103)

Example:

thread 'main' panicked at 'internal error: entered unreachable code: while processing package trio: accum_term = 0.19 isn't a subset of incompat_term = 0.19.0, which means the last assignment should have been a decision, but instead it was a derivation. This shouldn't be possible! (Maybe your Version ordering is broken?)', /home/njs/src/pubgrub/src/internal/partial_solution.rs:411:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Fixes: pubgrub-rsgh-102
* feat: add logging to help debugging

* debug: impl Display for partial solution

* fix cherry picking

* Fix display of assignments in partial_solution

* debug: nits

Co-authored-by: Jacob Finkelman <[email protected]>
* refactor: introduce a trait for sets of versions

* refactor: port report and incompatibility to version set

* refactor: port errors to version set

* refactor: port partial solution to version set

* refactor: move DependencyConstraints to type_aliases

* refactor: port core to version set

* refactor: port solver to version set

* refactor: replace old modules with ones based on version_set

* refactor: update tests to version_set

* feat: add serde bounds to OfflineDependencyProvider

* refactor: update proptest.rs to VersionSet

* docs: fix links

* refactor: allow clippy type_complexity

* Small docs changes
* refactor: replace Range with a bounded implementation

* fix: rewrite range proptest strategy

* fix: deserialize SmallVec without Vec alloc

* fix: remove not_equals

* fix: re-add union and remove early out

* fix: renamed V to VS in bench

* refactor: simpler intersection

Co-authored-by: Jacob Finkelman <[email protected]>

* test: use deltas for range strategy

Co-authored-by: Jacob Finkelman <[email protected]>

* docs(range): added comment about discrete values

* More restrictive for valid random range generation

* Remove duplicate check in check_invariants

* Add warning about non-unique ranges representations

* Rename start_bounded into start_unbounded

Co-authored-by: Jacob Finkelman <[email protected]>
Co-authored-by: Matthieu Pizenberg <[email protected]>
- Reduces nesting, to increase legibility of code
- Turns expect into error
- Removes unwrap()
BREAKING CHANGE: Changes the API of DependencyProvider
@zanieb
Copy link
Member Author

zanieb commented Nov 16, 2023

Sorry! This is intended to be in my fork.

@zanieb zanieb closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.