Re-vendor the carried hub files to the current canonical - #255
Merged
Conversation
These files are carried verbatim from ptr727/ProjectTemplate, so a local copy that differs is drift rather than a choice. The hub's regenerated fleet divergence report lists this repo for them. Changed: .markdownlint-cli2.jsonc repo-config/configure.sh Line endings preserved as each file held them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #255 +/- ##
========================================
Coverage 99.53% 99.53%
========================================
Files 7 7
Lines 860 860
Branches 118 118
========================================
Hits 856 856
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-vendors two “carried” repository-admin files to match the current canonical versions used across the fleet: the Markdown lint configuration and the repo-config apply/check script.
Changes:
- Update
repo-config/configure.shto the newer payload-driven apply/check flow (model selection, idempotent ruleset upserts, and drift checks). - Update
.markdownlint-cli2.jsoncto enable MD033 with an allowlist fordetails/summarywhile keeping long-line handling unchanged.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
repo-config/configure.sh |
Replaced the older apply/check implementation with the newer canonical, payload-driven model-selection and drift-check logic. |
.markdownlint-cli2.jsonc |
Switched MD033 from disabled to enabled with an allowlist for details/summary and updated explanatory comments. |
The canonical script resolves its ruleset payloads as develop.json and
main.json, and this repo carries ruleset-develop.json and ruleset-main.json.
Copying the script in therefore leaves apply and check aborting on payloads
that do not exist, which is worse than the older script it replaced.
The hub's divergence ledger records exactly this ("an older check-mode fork
with ruleset-*.json filenames"), so the information was available and the
re-vendor was run without acting on it. Converging this repo needs the
payload migration and its content reconciled against the canonical, which is
a change with judgment in it rather than a file copy, so it gets its own
pull request.
The markdownlint config re-vendor in this branch is unaffected and stays.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.markdownlint-cli2.jsoncis carriedverbatimfrom ptr727/ProjectTemplate, so a copy that differs is drift rather than a choice. The hub's regenerated fleet divergence report lists this repo for it.The canonical enables
MD033withdetailsandsummaryallowed, which is a behavior change rather than a comment sweep. Verified rather than assumed, since that is the kind of change that fails CI after the fact:markdownlint-cli2over**/*.mdreports 0 issues here under the restored config.Line endings preserved.
repo-config/configure.shwas withdrawn from this pull requestAn earlier revision of this branch also re-vendored
repo-config/configure.sh, and this description still described it after the file was removed. That was a stale description rather than a missing commit, and it is corrected here.The reason it was withdrawn is worth stating, because it is the blocker for this repo: the canonical script resolves its ruleset payloads as
develop.jsonandmain.json, and this repo carriesruleset-develop.jsonandruleset-main.json. Copying the script in leavesapplyandcheckaborting on payloads that do not exist, which is worse than the older script it replaced. The hub's divergence ledger recorded the filename fork, so the information was available and the re-vendor ran without acting on it.Converging this repo needs the payload migration with its content reconciled against the canonical, which is judgment rather than a file copy, so it gets its own pull request. Known defects in the canonical script are tracked at ptr727/ProjectTemplate#538 and fixed in ptr727/ProjectTemplate#540, which should land before that migration so this repo takes a corrected script rather than the current one twice.
Part of the fleet re-vendor sweep tracked in the hub's
TODO.md.