Skip to content

Invert Input Order So the History-Sort Test Actually Exercises It #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptr727 merged 2 commits into from
Aug 24, 2026
Merged

Invert Input Order So the History-Sort Test Actually Exercises It #971

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5645ad
Invert Input Order So the History-Sort Test Actually Exercises It
ptr727 Aug 24, 2026
216c8c4
Distinguish Timestamp Sorting From Number and Query-Order Sorting
ptr727 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/tests/test_pr_review.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2563,7 +2563,10 @@ class TestCopilotHistoryReadings(GqlCase):
"""The readings built from the reviewer's own review history across the repository."""

def test_history_sorts_by_timestamp_regardless_of_pull_request_order(self) -> None:
"""The query orders pull requests by their own update time, not by when each round landed."""
"""The query orders pull requests by their own update time, not by when each round
landed. The mocked nodes carry the EARLY one first, the opposite of the expected
result, so a passthrough that trusted the query's own order would fail this rather
than pass it by coincidence."""
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
self.answer(payload([]))
self.enterContext(
mock.patch.object(
Expand All @@ -2573,8 +2576,8 @@ def test_history_sorts_by_timestamp_regardless_of_pull_request_order(self) -> No
"repository": {
"pullRequests": {
"nodes": [
hist_review(962, QUOTA_REFUSED, at=LATE),
hist_review(900, QUOTA_REFUSED, at=EARLY),
hist_review(962, QUOTA_REFUSED, at=LATE),
]
}
}
Expand Down