Skip to content

Document dotnet/nbgv@master exception and drop redundant secrets: inherit #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptr727 merged 2 commits into from
May 11, 2026
Merged

Document dotnet/nbgv@master exception and drop redundant secrets: inherit #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06f3b84
Document dotnet/nbgv@master exception and drop redundant secrets: inh…
ptr727 May 11, 2026
e447f41
Reword nbgv exception comment: clarify deviation is documented here
ptr727 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build-nugetlibrary-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jobs:
get-version:
name: Get version information job
uses: ./.github/workflows/get-version-task.yml
secrets: inherit

build-nugetlibrary:
name: Build NuGet library project job
Expand Down
17 changes: 17 additions & 0 deletions .github/workflows/get-version-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,23 @@ jobs:
with:
fetch-depth: 0

# `dotnet/nbgv` is intentionally floated on `master` rather than
# pinned to a commit SHA — a deliberate deviation from the
# AGENTS.md "pin third-party actions to a commit SHA" rule,
# documented here so the deviation isn't accidentally "fixed" by
# a future reviewer. Justification:
# - The upstream tag stream is effectively dormant — the latest
# tag `v0.5.1` lags well behind `master` and fixes accumulate
# on `master` between tag bumps.
# - Dependabot's GitHub Actions ecosystem tracks tagged
# releases. A SHA pinned to a post-`v0.5.1` `master` commit
# would either receive no Dependabot updates (silently stale)
# or get an attempted downgrade PR to `v0.5.1`'s SHA. Neither
# beats just floating on `master`.
# - Upstream owner is Microsoft (`dotnet/`), so the
# "tag-/branch-retargeting risk" the AGENTS.md rule guards
# against is materially lower than for a random author.
# Revisit if `dotnet/nbgv` resumes regular tagged releases.
- name: Run Nerdbank.GitVersioning tool step
id: nbgv
uses: dotnet/nbgv@master
Loading