Skip to content

Develop - #2

Merged
ptr727 merged 22 commits into
mainfrom
develop
Jan 15, 2026
Merged

Develop#2
ptr727 merged 22 commits into
mainfrom
develop

Conversation

@ptr727

@ptr727 ptr727 commented Jan 15, 2026

Copy link
Copy Markdown
Owner

No description provided.

ptr727 added 12 commits January 13, 2026 20:44
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 15, 2026 02:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the project's CI/CD workflows and development environment configuration. The changes consolidate workflow files, update documentation for developer setup, and improve build processes.

Changes:

  • Consolidated GitHub Actions workflows by merging separate PR test workflows into a unified test-pull-request workflow
  • Enhanced README documentation with comprehensive developer environment setup instructions including SSH key configuration, git signing, and GitHub project settings
  • Refactored build workflows to separate library and executable build tasks with artifact management

Reviewed changes

Copilot reviewed 19 out of 24 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
Tests/Tests.csproj Updated xunit.analyzers version from 1.26.0 to 1.27.0
README.md Expanded developer setup documentation with SSH configuration, git signing, secrets setup, and GitHub project settings
ProjectTemplate.slnx Added GitHub Actions workflow files to solution and alphabetically reordered project entries
ProjectTemplate.code-workspace Added git and GitHub Local Actions configuration settings, removed obsolete extension recommendation
Library/Library.csproj Added Benchmarks to InternalsVisibleTo for internal access
Docker/Version.sh New shell script for printing Docker container version information
Docker/InstallDebugTools.sh New shell script for installing VS debugger and .NET diagnostic tools
Docker/Build.sh New shell script for building and publishing .NET projects in Docker
Console/Console.csproj Added InternalsVisibleTo for Tests and Benchmarks, added Husky installation target
.husky/pre-commit New pre-commit hook script for running Husky tasks
.gitignore Added .artifacts directory to ignore list
.github/workflows/test-pull-request.yml New unified workflow for testing pull requests against main and develop branches
.github/workflows/test-project-task.yml Updated code style check to use Husky instead of direct CSharpier and dotnet format
.github/workflows/test-pr.yml Removed - consolidated into test-pull-request.yml
.github/workflows/test-docker-task.yml Updated job name and added inline comment
.github/workflows/test-docker-pr.yml Removed - consolidated into test-pull-request.yml
.github/workflows/test-build-pr.yml Removed - consolidated into test-pull-request.yml
.github/workflows/publish-docker-release.yml Added permissions, inline comments, and schedule documentation
.github/workflows/publish-build-release.yml Updated workflow name, added permissions and inline comments
.github/workflows/date-badge-task.yml Added IS_MAIN_BRANCH environment variable, moved condition from job to step level
.github/workflows/build-project-task.yml Major refactor to split library and executable builds with artifact management
.github/workflows/build-library-task.yml New workflow for building library projects with artifact output
.github/workflows/build-executable-task.yml New workflow for building executables across multiple platforms using matrix strategy
.github/workflows/build-docker-task.yml Removed matrix strategy, simplified to single docker build with environment variables

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread .github/workflows/build-executable-task.yml Outdated
Comment thread .github/workflows/build-library-task.yml Outdated
Comment thread .github/workflows/build-executable-task.yml Outdated
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 24 changed files in this pull request and generated 2 comments.

Comment thread README.md Outdated
Comment thread .github/workflows/build-docker-task.yml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 15, 2026 03:48
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 24 changed files in this pull request and generated 8 comments.

Comment thread ProjectTemplate.slnx Outdated
Comment thread .github/workflows/date-badge-task.yml
Comment thread .github/workflows/build-project-task.yml Outdated
Comment thread .github/workflows/build-library-task.yml Outdated
Comment thread .github/workflows/build-executable-task.yml Outdated
Comment thread .github/workflows/build-docker-task.yml Outdated
Comment thread .github/workflows/build-docker-task.yml Outdated
Comment thread .github/workflows/build-docker-task.yml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 15, 2026 03:54
ptr727 and others added 2 commits January 14, 2026 22:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 24 changed files in this pull request and generated 6 comments.

Comment thread ProjectTemplate.code-workspace
Comment thread README.md Outdated
Comment thread .github/workflows/build-library-task.yml
Comment thread ProjectTemplate.slnx
Comment thread .github/workflows/build-executable-task.yml Outdated
Comment thread .github/workflows/build-docker-task.yml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 15, 2026 04:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 24 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

.github/workflows/test-project-task.yml:27

  • The Husky task configuration uses csharpier format which modifies files, but this is being run in the CI pipeline where you typically want to verify formatting without making changes. The original workflow used csharpier check which only validates. Consider whether the format command is appropriate for CI, or if it should remain as check to fail the build when formatting issues are detected without modifying files.

Comment thread README.md
Comment thread .github/workflows/build-executable-task.yml
Comment thread .github/workflows/build-project-task.yml
Comment thread .github/workflows/build-docker-task.yml Outdated
Comment thread .github/workflows/build-project-task.yml
Comment thread README.md Outdated
Copilot AI review requested due to automatic review settings January 15, 2026 04:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 24 changed files in this pull request and generated 3 comments.

Comment thread README.md
Comment thread README.md Outdated
Comment thread ProjectTemplate.code-workspace

Copilot AI commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

@ptr727 I've opened a new pull request, #3, to work on those changes. Once the pull request is ready, I'll request review from you.

Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 15, 2026 05:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 24 changed files in this pull request and generated 1 comment.

Comment thread README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants