Skip to content

Address Promotion Review Nits: Self-Contained Comment and Clearer Local #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptr727 merged 1 commit into from
Jul 17, 2026
Merged

Address Promotion Review Nits: Self-Contained Comment and Clearer Local #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions PlexCleaner/FfProbeTool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,16 @@ public bool GetPackets(
[CallerMemberName] string operation = ""
)
{
// Wrap async function in a task
(bool result, string error) result = GetPacketsAsync(
// Run the async worker synchronously; deconstruct so the tuple does not shadow the error out-param
(bool ok, string packetError) = GetPacketsAsync(
command,
async packet => await Task.FromResult(packetFunc(packet)),
operation
)
.GetAwaiter()
.GetResult();
error = result.error;
return result.result;
error = packetError;
return ok;
}

public async Task<(bool result, string error)> GetPacketsAsync(
Expand Down
3 changes: 1 addition & 2 deletions RegressionTests/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# Linter-only configuration for the RegressionTests Python utilities.
#
# These are standalone stdlib-only scripts (no runtime dependencies), so this file carries no
# project/build metadata - only the ruff + mypy config, mirroring the ptr727 Financial-Modeling
# conventions. Run the tools with uv (no install needed):
# project/build metadata - only the ruff + mypy config. Run the tools with uv (no install needed):
#
# uvx ruff check .
# uvx ruff format --check .
Expand Down