Include the Operation and File Name in Verify Failure Logs - #857
Merged
Conversation
VerifyMedia streams stderr and logs its failures inline rather than through MediaTool.LogFailedResult, so it had not picked up the operation-name and file-name fields that the tool-failure logging convention adds. Align both inline templates with that convention so a verify decode-error failure is attributable to its file when processing in parallel. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Aligns FfMpegTool.VerifyMedia failure logging with the standard tool-failure format (MediaTool.LogFailedResult) by including the operation and file name in the inline (streaming-stderr) error logs, improving attribution when files are processed in parallel (noted from the develop->main promotion in #856).
Changes:
- Add
{Operation:l}and{FileName}fields to the twoVerifyMediafailure log templates (with/without error summary). - Use
nameof(VerifyMedia)and the in-scopefileNameso the emitted message shape matchesMediaTool.LogFailedResult.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FfMpegTool.VerifyMediastreams stderr and logs its failures inline (it has the classified errorlines, not a
BufferedCommandResult), so it never picked up the{Operation:l}and{FileName}fields that
MediaTool.LogFailedResultadds. Align both inline templates with that convention, usingnameof(VerifyMedia)for the operation and the in-scopefileName, so a verify decode-error failureis attributable to its file when files process in parallel.
Surfaced by the Copilot review on the develop→main promotion (#856). The regression log parser
already accepts this fuller format, and the existing
ToolFailureLogFormatTestscover theLogFailedResulttemplate this now matches.🤖 Generated with Claude Code