Produce full output for the setts timestamp repair - #836
Merged
Conversation
setts is a lossless stream-copy repair, but it honored --testsnippets and wrote a 30s snippet in test mode, so the byte-identical regression gate (full source vs snippet output) failed and a genuinely repairable file was marked RepairFailed. A snippet also can not represent the whole file - some files pass on a snippet and fail on the full file - so the repair must be validated on the full output. Drop TestSnippets from SetTimestamps so the gate and re-verify cover the entire file. Also carry the README release-notes edit (current-version summary only) and note in AGENTS.md that README carries only the current version.
There was a problem hiding this comment.
Pull request overview
Fixes a regression in the lossless setts timestamp repair path where --testsnippets caused SetTimestamps to emit a short snippet, breaking the byte-identical regression gate and re-verify that must validate the full output.
Changes:
- Stop applying
.TestSnippets()toFfMpegTool.SetTimestamps()so the repair always produces a full-length output for hashing + verification. - Update README release notes to keep only the current version summary, referencing
HISTORY.mdfor older notes. - Document in
AGENTS.mdthatREADME.mdshould contain only the current version's summary (older versions belong inHISTORY.md).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Simplifies release notes to current-version-only summary and points to HISTORY for older notes. |
| PlexCleaner/FfMpegTool.cs | Ensures setts repair outputs the full file even under --testsnippets, aligning with the byte-identical gate and re-verify. |
| AGENTS.md | Captures the README release-notes convention (current version only; older notes in HISTORY). |
ptr727
added a commit
that referenced
this pull request
Jul 14, 2026
Fast stream-copy and remux operations no longer honor --testsnippets, so remuxes and the lossless timestamp repair produce full output validated on the whole file. Kept on the re-encode and deinterlace paths. Also fixes a README release-note grammar nit. Follow-up to #836.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #835. Found by comparing a 3.21 regression run against the 3.20 baseline.
SetTimestamps(the losslesssettsrepair) honored--testsnippets, so in test mode it wrote a 30-second snippet. The byte-identical regression gate then compared the full source hash against the snippet output hash, failed, and marked a genuinely repairable fileRepairFailed(e.g. Ghosted S01E04, which repairs correctly in production). More importantly, a snippet can not represent the whole file - some files pass on a snippet and fail on the full file - so the repair's gate and re-verify must cover the entire output.settsis a fast stream-copy, so full output in test mode costs seconds. Unlike a re-encode, there is no reason to snippet it, and doing so undermines the validation. Drop.TestSnippets()fromSetTimestamps.Also included:
207 tests pass; build, format, markdownlint clean.
🤖 Generated with Claude Code