env also not supported in job if

ptr727 · Jun 18, 2023 · 208379d · 208379d
1 parent d7a16aa
commit 208379d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/BuildDockerPush.yml b/.github/workflows/BuildDockerPush.yml
@@ -13,7 +13,7 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
-# env is not supported in matrix operations :(
+# env is not supported in matrix operations or job if :(
 env:
   # Do not push on pull_request events
   dopush: ${{ github.event_name != 'pull_request' }}
@@ -187,7 +187,7 @@ jobs:
     name: Tool versions
     runs-on: ubuntu-latest
     needs: buildpush
-    if: ${{ env.dopush }}
+    if: ${{ github.event_name != 'pull_request' }}
 
     strategy:
 
@@ -239,7 +239,7 @@ jobs:
     name: Create README.md
     runs-on: ubuntu-latest
     needs: toolversions
-    if: ${{ env.dopush }}
+    if: ${{ github.event_name != 'pull_request' }}
 
     steps:
 
@@ -272,7 +272,7 @@ jobs:
     name: Update README.md
     runs-on: ubuntu-latest
     needs: updatereadme
-    if: ${{ (env.dopush }}
+    if: ${{ github.event_name != 'pull_request' }}
 
     steps:
 
@@ -297,7 +297,7 @@ jobs:
     name: Date badge
     runs-on: ubuntu-latest
     needs: buildpush
-    if: ${{ env.dopush }}
+    if: ${{ github.event_name != 'pull_request' }}
 
     steps:
 

diff --git a/.github/workflows/BuildGitHubRelease.yml b/.github/workflows/BuildGitHubRelease.yml
@@ -11,7 +11,7 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
-# env is not supported in matrix operations :(
+# env is not supported in matrix operations or job if :(
 env:
   # Do not push on pull_request events
   dopush: ${{ github.event_name != 'pull_request' }}
@@ -137,7 +137,7 @@ jobs:
     name: Publish
     runs-on: ubuntu-latest
     needs: [ build, version ]
-    if: ${{ env.dopush }}
+    if: ${{ github.event_name != 'pull_request' }}
 
     steps: