Conversation
Replace the local HttpClientFactory and AssemblyInfo copies with the shared ptr727.Utilities 4.0.7 versions; wire the library logger via LogOptions.SetFactory. Delete the local copies and drop the direct Microsoft.Extensions.Http.Resilience reference.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 15 15
Lines 232994 232994
Branches 243 243
=======================================
Hits 232450 232450
Misses 462 462
Partials 82 82 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes to main the switch in LanguageTagsCreate from local implementations to the shared ptr727.Utilities package for HTTP client creation and shared assembly/logging utilities, reducing duplicated code in the codegen tool.
Changes:
- Replace the local
LanguageTagsCreateHttpClientFactorywithptr727.Utilities.HttpClientFactory. - Wire the shared
ptr727.Utilities.LogOptionsto the existing Serilog-backedILoggerFactory. - Remove the local
HttpClientFactory.csandAssemblyInfo.csand addptr727.Utilities4.0.7to central package versions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| LanguageTagsCreate/Program.cs | Sets both ptr727.LanguageTags.LogOptions and ptr727.Utilities.LogOptions to the same ILoggerFactory. |
| LanguageTagsCreate/LanguageTagsCreate.csproj | Replaces direct resilience-related dependency usage with a ptr727.Utilities package reference. |
| LanguageTagsCreate/HttpClientFactory.cs | Removes the local resilience-enabled HttpClient factory implementation. |
| LanguageTagsCreate/CreateTagData.cs | Switches download stream acquisition to Utilities.HttpClientFactory.GetClient(). |
| LanguageTagsCreate/AssemblyInfo.cs | Removes the local assembly metadata helper previously used by the old HTTP client factory. |
| Directory.Packages.props | Drops the now-unused resilience package version and adds ptr727.Utilities 4.0.7. |
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes to main the adoption of the shared ptr727.Utilities
4.0.7HttpClientFactory/AssemblyInfoin place of the local copies.LanguageTagsCreatereferencesptr727.Utilitiesand deletes its localHttpClientFactory.cs/AssemblyInfo.cs.Utilities.HttpClientFactory.GetClient(); the resilience pipeline and AOT-safe User-Agent come from the library.ILoggerlogging is wired viaUtilities.LogOptions.SetFactory(...).Verified: build clean,
dotnet format styleclean, 296 tests passing.🤖 Generated with Claude Code