Skip to content

Adopt ptr727.Utilities HttpClientFactory and drop local copies #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptr727 merged 3 commits into from
Jul 10, 2026
Merged

Adopt ptr727.Utilities HttpClientFactory and drop local copies #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
511c4e6
Adopt ptr727.Utilities HttpClientFactory and drop local copies
ptr727 Jul 10, 2026
3256fae
Capture shared logger factory once and drop unused package version
ptr727 Jul 10, 2026
f5d7ca3
Reference the released ptr727.Utilities 4.0.7
ptr727 Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
<ItemGroup>
<PackageVersion Include="AwesomeAssertions" Version="9.4.0" />
<PackageVersion Include="coverlet.collector" Version="10.0.1" />
<PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="10.7.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.9" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.7.0" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.300" />
<PackageVersion Include="ptr727.Utilities" Version="4.0.7" />
<PackageVersion Include="Serilog" Version="4.3.1" />
<PackageVersion Include="Serilog.Enrichers.Thread" Version="4.0.0" />
Comment thread
ptr727 marked this conversation as resolved.
<PackageVersion Include="Serilog.Extensions.Logging" Version="10.0.0" />
Expand Down
45 changes: 0 additions & 45 deletions LanguageTagsCreate/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions LanguageTagsCreate/CreateTagData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ private async Task DownloadFileAsync(Uri uri, string fileName)

Log.Information("Downloading \"{Uri}\" to \"{FileName}\" ...", uri.ToString(), fileName);

using Stream httpStream = await HttpClientFactory
.GetHttpClient()
using Stream httpStream = await Utilities
.HttpClientFactory.GetClient()
.GetStreamAsync(uri, cancellationToken)
.ConfigureAwait(false);

Expand Down
120 changes: 0 additions & 120 deletions LanguageTagsCreate/HttpClientFactory.cs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion LanguageTagsCreate/LanguageTagsCreate.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<ProjectReference Include="..\LanguageTags\LanguageTags.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Http.Resilience" />
<PackageReference Include="ptr727.Utilities" />
<PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="all" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
<PackageReference Include="Serilog.Enrichers.Thread" />
Expand Down
4 changes: 3 additions & 1 deletion LanguageTagsCreate/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ internal static async Task<int> Main(string[] args)
Log.Logger = LoggerFactory.Create(
commandLine.CreateOptions(commandLine.Result).LogOptions
);
LogOptions.SetFactory(LoggerFactory.CreateLoggerFactory());
ILoggerFactory loggerFactory = LoggerFactory.CreateLoggerFactory();
LogOptions.SetFactory(loggerFactory);
Utilities.LogOptions.SetFactory(loggerFactory);

// Invoke command
Log.Logger.LogOverrideContext().Information("Starting: {Args}", args);
Expand Down