Refactor project configuration and update dependencies (#118) by ptr727 · Pull Request #119 · ptr727/LanguageTags

ptr727 · 2026-04-14T00:48:52Z

Updated build-library-task.yml to specify OutputPath and PackageOutputPath for dotnet build.
Changed concurrency group in run-periodic-codegen-pull-request.yml to target main/codegen.
Modified launch.json to reflect new output paths for the LanguageTagsCreate project.
Enhanced AGENTS.md with project configuration guidelines and centralized NuGet package versions.
Updated LanguageData/rfc5646 and LanguageData/rfc5646.json with new language subtags and descriptions.
Cleaned up GlobalUsings.cs files by removing unused namespaces.
Adjusted LanguageTags.csproj and LanguageTagsCreate.csproj to centralize package versions and remove unnecessary properties.
Improved HttpClientFactory.cs with resilience strategies using Polly for better error handling.
Added Directory.Build.props and Directory.Packages.props for centralized project settings and package version management.
Updated LanguageTagsTests project to remove unnecessary properties and centralize package references.

Copilot

Pull request overview

Refactors solution-wide build/package configuration (central MSBuild defaults + central NuGet versions), updates the RFC 5646 registry data, and adjusts CI/codegen workflows and the codegen tool’s HTTP resilience behavior.

Changes:

Centralized MSBuild defaults and NuGet package versions via Directory.Build.props and Directory.Packages.props, and simplified individual project files accordingly.
Updated codegen automation/workflows (concurrency, permissions, PR creation/triggering) and developer tooling configuration.
Refreshed RFC 5646 language subtag registry sources and regenerated the corresponding C# data.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`Directory.Build.props`	Adds repo-wide MSBuild defaults (TFM, analyzers, warnings-as-errors, central package mgmt, artifacts path).
`Directory.Packages.props`	Introduces central NuGet package version management.
`LanguageTags/LanguageTags.csproj`	Removes duplicated analyzer/framework settings; switches to centrally-managed package versions; explicitly marks library packable.
`LanguageTagsCreate/LanguageTagsCreate.csproj`	Removes duplicated analyzer/framework settings; switches to centrally-managed package versions.
`LanguageTagsTests/LanguageTagsTests.csproj`	Removes duplicated analyzer/framework settings; switches to centrally-managed package versions.
`LanguageTagsCreate/HttpClientFactory.cs`	Expands Polly resilience with retry/circuit breaker logging and shared handler configuration tweaks.
`LanguageTags*/GlobalUsings.cs` (all)	Removes unused global using directives.
`LanguageTags/LogOptions.cs`	Removes an unused `using`.
`LanguageData/rfc5646`	Updates raw IANA registry snapshot (new/updated subtags, metadata).
`LanguageData/rfc5646.json`	Updates JSON-converted registry snapshot (aligned with raw update).
`LanguageTags/Rfc5646DataGen.cs`	Regenerates embedded RFC 5646 dataset C# code with updated records/date.
`.github/workflows/build-library-task.yml`	Builds using explicit `OutputPath`/`PackageOutputPath` rather than `--output`.
`.github/workflows/run-periodic-codegen-pull-request.yml`	Adjusts concurrency grouping for the periodic codegen workflow.
`.github/workflows/run-codegen-pull-request-task.yml`	Uses `GITHUB_TOKEN` for PR creation; adds permissions; closes/reopens PR via PAT to trigger workflows.
`.github/workflows/merge-bot-pull-request.yml`	Updates merge conditions to align with codegen PRs authored by `github-actions[bot]`.
`.vscode/launch.json`	Updates debug target paths to `.artifacts` output.
`AGENTS.md`	Documents new centralized project configuration conventions.
`.github/copilot-instructions.md`	Updates documentation formatting and adds centralized project configuration guidance.

Copilot · 2026-04-14T00:52:41Z

            "preLaunchTask": ".Net Build",
-            "program": "${workspaceFolder}/LanguageTagsCreate/bin/Debug/net10.0/LanguageTagsCreate.dll",
+            "program": "${workspaceFolder}/.artifacts/bin/LanguageTagsCreate/debug/LanguageTagsCreate.dll",
            "args": [
                "--codepath",
                "${workspaceFolder}",
            ],
-            "cwd": "${workspaceFolder}/LanguageTagsCreate/bin/Debug/net10.0",
+            "cwd": "${workspaceFolder}/.artifacts/bin/LanguageTagsCreate/debug",
            "console": "internalConsole",


preLaunchTask runs .Net Build, which (per .vscode/tasks.json) just executes dotnet build with default output paths. This launch config now points program/cwd at /.artifacts/..., so debugging will fail unless the build is also configured to emit binaries there. Either update the build task/MSBuild props to output into .artifacts (e.g., enable the SDK artifacts output feature / set OutputPath) or revert program/cwd to the standard bin/Debug/<tfm> location.

Copilot · 2026-04-14T00:52:42Z

+    <AnalysisLevel>latest-all</AnalysisLevel>
+    <AnalysisMode>All</AnalysisMode>
+    <EnableNETAnalyzers>true</EnableNETAnalyzers>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>


ArtifactsPath is defined here, but nothing enables the SDK's artifacts output layout, so local builds will still emit to bin//obj/ by default. Since .vscode/launch.json was updated to reference /.artifacts/bin/..., consider explicitly enabling artifacts output (or setting OutputPath/BaseOutputPath consistently) so the .artifacts path actually exists after a normal dotnet build.

Suggested change

<TreatWarningsAsErrors>true</TreatWarningsAsErrors>

<TreatWarningsAsErrors>true</TreatWarningsAsErrors>

<UseArtifactsOutput>true</UseArtifactsOutput>

Copilot · 2026-04-14T00:52:42Z

+    private static bool IsTransientFailure(Outcome<HttpResponseMessage> outcome) =>
+        outcome.Exception is not null
+            ? outcome.Exception is not (OperationCanceledException or BrokenCircuitException)
+            : outcome.Result is not null && (int)outcome.Result.StatusCode is 408 or 429 or >= 500;
+


IsTransientFailure treats all OperationCanceledException as non-transient. This also includes TaskCanceledException raised by HttpClient.Timeout, so timeouts won’t be retried and won’t contribute to circuit-breaker metrics, reducing resilience for slow/transient connections. Consider distinguishing user-requested cancellation (don’t retry when the caller token is canceled) from timeouts (retry), e.g., by using the strategy callback args to check args.Context.CancellationToken.IsCancellationRequested or by adding a Polly timeout strategy and handling that exception type explicitly.

Suggested change

private static bool IsTransientFailure(Outcome<HttpResponseMessage> outcome) =>

outcome.Exception is not null

? outcome.Exception is not (OperationCanceledException or BrokenCircuitException)

: outcome.Result is not null && (int)outcome.Result.StatusCode is 408 or 429 or >= 500;

private static bool IsTransientFailure(Outcome<HttpResponseMessage> outcome)

{

if (outcome.Exception is BrokenCircuitException)

{

return false;

}

if (outcome.Exception is OperationCanceledException operationCanceledException)

{

return !IsUserCancellation(operationCanceledException);

}

if (outcome.Exception is not null)

{

return true;

}

return outcome.Result is not null && (int)outcome.Result.StatusCode is 408 or 429 or >= 500;

}

private static bool IsUserCancellation(OperationCanceledException exception) =>

exception.CancellationToken.CanBeCanceled && exception.CancellationToken.IsCancellationRequested;

Copilot AI review requested due to automatic review settings April 14, 2026 00:48

Copilot started reviewing on behalf of ptr727 April 14, 2026 00:49 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Refactor project configuration and update dependencies

7d5fdcc

ptr727 force-pushed the develop branch from 1910388 to 7d5fdcc Compare April 14, 2026 00:56

ptr727 merged commit 7d5fdcc into main Apr 14, 2026
6 checks passed

dependabot Bot mentioned this pull request Apr 22, 2026

Bump the nuget-deps group with 6 updates ptr727/PlexCleaner#689

Closed

dependabot Bot mentioned this pull request Apr 29, 2026

Bump the nuget-deps group with 6 updates ptr727/PlexCleaner#691

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor project configuration and update dependencies (#118)#119

Refactor project configuration and update dependencies (#118)#119
ptr727 merged 1 commit into
mainfrom
develop

ptr727 commented Apr 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
	<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
	<UseArtifactsOutput>true</UseArtifactsOutput>

-    private static bool IsTransientFailure(Outcome<HttpResponseMessage> outcome) =>
-        outcome.Exception is not null
-            ? outcome.Exception is not (OperationCanceledException or BrokenCircuitException)
-            : outcome.Result is not null && (int)outcome.Result.StatusCode is 408 or 429 or >= 500;
+    private static bool IsTransientFailure(Outcome<HttpResponseMessage> outcome)
+    {
+        if (outcome.Exception is BrokenCircuitException)
+        {
+            return false;
+        }
+        if (outcome.Exception is OperationCanceledException operationCanceledException)
+        {
+            return !IsUserCancellation(operationCanceledException);
+        }
+        if (outcome.Exception is not null)
+        {
+            return true;
+        }
+        return outcome.Result is not null && (int)outcome.Result.StatusCode is 408 or 429 or >= 500;
+    }
+    private static bool IsUserCancellation(OperationCanceledException exception) =>
+        exception.CancellationToken.CanBeCanceled && exception.CancellationToken.IsCancellationRequested;

Conversation

ptr727 commented Apr 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants