Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Creation in AdminCP #13

Merged
merged 1 commit into from
Dec 14, 2015
Merged

Account Creation in AdminCP #13

merged 1 commit into from
Dec 14, 2015

Conversation

DDynamic
Copy link
Contributor

This allows accounts to be created in the Admin Control Panel. It was tested manually.

@DaneEveritt remember to add in UUID checking when you get a chance.


use Pterodactyl\Models\User as User;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to define this as User since it is implied that it is User by the namespace. If it was say Pterodactyl\Models\LongUserNamespaceKindaVague you could tack on as User to make it easier to write and read.

@DaneEveritt
Copy link
Member

In addition to those line specific notes, you're using double quotes (") in the JS, I'd prefer we stick to the standard of single quotes (') for the JS.

You're also using tabs in place of 4 spaces.

Thanks for the PR, I'll pull it once we get that stuff fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants