This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
Added User-Agent #113
Closed
Added User-Agent #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could see people abusing this by sending requests as that user-agent then. |
|
While that is true and it is a concern, it's still a lot simpler than having to whitelist IPs in the case you are firewalling based on AS numbers. |
|
There's also a lot more requests than the 2 that were changed (https://github.com/pterodactyl/daemon/search?q=Request&unscoped_q=Request), and the User-Agent probably should pull the version from package.json instead of relying on hardcoding it in every place. |
|
Ah, good find. Would you like me to fix that up and commit again? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added User-Agent to allow for easier traffic filtration on Cloudflare.
Case:
Someone has 50+ nodes and has strict firewalling set up on Cloudflare.
Deploying a new node means the account user will have to add another rule to allow that server to pass through.
Adding a User-Agent will drastically simplify that process since the account user only has to allow
User-Agent to pass through rather than whitelisting an empty UA which is commonly used by other attackers too.