Security Vulnerabilities #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with vulnerabilities
|
FYI @Smullz622 , since we decided to move ScholarSphere development back a bit, I decided to take a stab at this and potentially figure out what is going on with selenium. There does seem to be some java issue with v4.15 ( SeleniumHQ/selenium#13091 ) that the SeleniumHQ team is looking into. I was getting similar errors in CI that you were getting locally with the v4.15 selenium/standalone-chrome image. I pinned this at v4.14 and pinned the selenium-webdriver gem at v4.14. It works at this version. It might be a good idea to just keep these pinned at a working version indefinitely. That way we aren't constantly wrestling with latest release bugs, or incompatibilities with webdriver gems, the webdrivers themselves, and the browsers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates packages to resolve vulnerabilities. Removes unneeded packages with vulnerabilities
closes #699