Stop thread if still running in destructor

Threads addressed in this commit: - Transmitter (txThread, txStats) - Capturer - EmulXcvr
pstavirs · Nov 24, 2023 · f185ceb · f185ceb
1 parent cf84060
commit f185ceb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/server/pcapport.cpp b/server/pcapport.cpp
@@ -401,6 +401,8 @@ PcapPort::PortCapturer::PortCapturer(const char *device)
 
 PcapPort::PortCapturer::~PortCapturer()
 {
+    if (isRunning())
+        stop();
     capFile_.close();
 }
 
@@ -549,7 +551,8 @@ PcapPort::EmulationTransceiver::EmulationTransceiver(const char *device,
 
 PcapPort::EmulationTransceiver::~EmulationTransceiver()
 {
-    stop();
+    if (isRunning())
+        stop();
 }
 
 void PcapPort::EmulationTransceiver::run()
@@ -738,7 +741,7 @@ void PcapPort::EmulationTransceiver::stop()
             QThread::msleep(10);
     }
     else {
-        qWarning("Receive stop requested but is not running!");
+        qWarning("Emulation Xcvr stop requested but is not running!");
         return;
     }
 }

diff --git a/server/pcaptransmitter.cpp b/server/pcaptransmitter.cpp
@@ -34,6 +34,10 @@ PcapTransmitter::PcapTransmitter(
 
 PcapTransmitter::~PcapTransmitter()
 {
+    if (txThread_.isRunning())
+        txThread_.stop();
+    if (txStats_.isRunning())
+        txStats_.stop();
 }
 
 bool PcapTransmitter::setRateAccuracy(