Add comment specifying PDML reader needs PCAP file

Updates #238
pstavirs · Jan 15, 2022 · d09d830 · d09d830
1 parent 0f322fb
commit d09d830
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/common/pcapfileformat.cpp b/common/pcapfileformat.cpp
@@ -236,6 +236,9 @@ bool PcapFileFormat::open(const QString fileName,
 
     pktBuf.resize(fileHdr.snapLen);
 
+    // XXX: PDML also needs the PCAP file to cross check packet bytes
+    // with the PDML data, so we can't do PDML conversion any earlier
+    // than this
     qDebug("pdml check");
     if (importOptions_.value("ViaPdml").toBool())
     {
@@ -275,6 +278,8 @@ bool PcapFileFormat::open(const QString fileName,
 
         emit status("Reading PDML packets...");
         emit target(100); // in percentage
+
+        // pdml reader needs pcap, so pass self
         isOk = reader.read(&pdmlFile, this, &stop_);
 
         if (stop_)