Skip to content

No screen blink on quick menus and button presses; 54ms unit gap; ACID filter pictures - #133

Merged
pssdrnk-cmyk merged 1 commit into
jam11from
b13-ui-flicker
Nov 15, 2026
Merged

pssdrnk-cmyk merged 1 commit into
jam11from
b13-ui-flicker

Conversation

@pssdrnk-cmyk

Copy link
Copy Markdown
Owner

What and why

The screen no longer blinks when a quick menu opens or closes or a button changes the page (owner on 1.0.0-b13). A full redraw filled the whole body with the background first and the new page came in over it for about 70 ms. Now nothing is filled first: every transfer marks the pixels it covers and only the uncovered ones get the background at the end of the pass, so each pixel goes straight from the old picture to the new one. The same PR fixes three smaller blinks (the MIXER's H M L bands, the cards under QUICK SEQ's and PARAMETER LOCKS' step strip, and dialogs / the count-in, which blinked on every beat), item 156 (a value ending in 4 touched its unit: "54ms") and the ACID filter pictures (now on the ACID RES law).

Measured on the host harness (a pixel flashed = showed a value that was neither its old nor its new one within a frame):

jam11 a264347 this PR
every button tapped and held on MORPH, AMP ENV, AUTO TIDE (180 events) 88 flash, up to 9,676 px 0
every page, knob, quick layer, MENU, count-in (1,718 events) 340 flash 0

Findings per menu and button: work/b13/ui/FLICKER.md. Frame sequences of QUICK EDIT opening and closing, before and after (1x, boxed): work/b13/ui/flicker_sequence.png.

Checked

  • Builds and fits: the slot's 208 B free (jam11: 92 B; the old gap tables and gutter tracker are gone). Pool 351,040 of 368,640 B (+6,592 for the coverage map, the 8 KiB tail kept). Hot placement ok.
  • Pictures (host renders, TIDE palette); not tried on the unit.
  • Docs: KNOWN_ISSUES loses the VOICE 2/2 and ACID drawing rows; host_tests.sh's uigaps line.
  • changes/b13-ui-flicker.md
  • Test groups run: uigaps (new: no page change fills the whole body; no press flashes; FAILS on jam11), ui, ui-about-tide, uitest, uf: all PASS.

Not in this PR: the grey key chips (OCT- NO in dialogs, GLO / OCT- in MIXER). Every chip uses the one T_KEY grey; teal for all is 0 B but vanishes on a muted MIXER card (part-colour fill), so it needs a contrast rule (bytes, and a look choice).

🤖 Generated with Claude Code

…nit gap; ACID filter pictures on the ACID RES law

- A full redraw no longer fills the body with the BG first: every transfer marks the pixels it covers (gfx.c gut_cov, one bit a pixel, rows 24..239, 6,912 B in the pool) and gut_flush gives only the uncovered ones the BG at the end of the pass. The per-layout gap tables, the gutter tracker, gap_rows and draw_gaps are gone.
- MIXER / QUICK GLO: the H M L bands are drawn in the panel's own picture (ui_lmh.c lmh_card), not sent over a plain card after it.
- QUICK SEQ, PARAMETER LOCKS and the other step-strip pages: the card row stops where the footer's step strip starts (it was drawn over it).
- Dialogs, the count-in (every beat) and UPDATE MODE: the same end-of-pass fill (body_clear).
- Item 156: a unit starts 1 px past its value's ink (a "4" ends its ink at its pen: "54ms" touched).
- ACID / ACSQ: the MULTI FILTER, TWIN and live filter pictures use UF_KA / UF_K24BA as the engine does.
- uigaps: no page change fills the whole body; every button tapped and held on MORPH, AMP ENV, AUTO TIDE, a dialog and a count-in flash no pixel (88 of these cases flashed before).

Flash: the slot's 208 B free (jam11 a264347: 92 B). Pool: 351,040 of 368,640 B (+6,592).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pssdrnk-cmyk
pssdrnk-cmyk merged commit 51ba394 into jam11 Nov 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant