Repository navigation
No screen blink on quick menus and button presses; 54ms unit gap; ACID filter pictures - #133
Merged
Merged
Conversation
…nit gap; ACID filter pictures on the ACID RES law - A full redraw no longer fills the body with the BG first: every transfer marks the pixels it covers (gfx.c gut_cov, one bit a pixel, rows 24..239, 6,912 B in the pool) and gut_flush gives only the uncovered ones the BG at the end of the pass. The per-layout gap tables, the gutter tracker, gap_rows and draw_gaps are gone. - MIXER / QUICK GLO: the H M L bands are drawn in the panel's own picture (ui_lmh.c lmh_card), not sent over a plain card after it. - QUICK SEQ, PARAMETER LOCKS and the other step-strip pages: the card row stops where the footer's step strip starts (it was drawn over it). - Dialogs, the count-in (every beat) and UPDATE MODE: the same end-of-pass fill (body_clear). - Item 156: a unit starts 1 px past its value's ink (a "4" ends its ink at its pen: "54ms" touched). - ACID / ACSQ: the MULTI FILTER, TWIN and live filter pictures use UF_KA / UF_K24BA as the engine does. - uigaps: no page change fills the whole body; every button tapped and held on MORPH, AMP ENV, AUTO TIDE, a dialog and a count-in flash no pixel (88 of these cases flashed before). Flash: the slot's 208 B free (jam11 a264347: 92 B). Pool: 351,040 of 368,640 B (+6,592). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pssdrnk-cmyk
force-pushed
the
b13-ui-flicker
branch
from
November 15, 2026 23:38
7a84e53 to
ed136d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The screen no longer blinks when a quick menu opens or closes or a button changes the page (owner on 1.0.0-b13). A full redraw filled the whole body with the background first and the new page came in over it for about 70 ms. Now nothing is filled first: every transfer marks the pixels it covers and only the uncovered ones get the background at the end of the pass, so each pixel goes straight from the old picture to the new one. The same PR fixes three smaller blinks (the MIXER's H M L bands, the cards under QUICK SEQ's and PARAMETER LOCKS' step strip, and dialogs / the count-in, which blinked on every beat), item 156 (a value ending in 4 touched its unit: "54ms") and the ACID filter pictures (now on the ACID RES law).
Measured on the host harness (a pixel flashed = showed a value that was neither its old nor its new one within a frame):
Findings per menu and button:
work/b13/ui/FLICKER.md. Frame sequences of QUICK EDIT opening and closing, before and after (1x, boxed):work/b13/ui/flicker_sequence.png.Checked
changes/b13-ui-flicker.mdNot in this PR: the grey key chips (OCT- NO in dialogs, GLO / OCT- in MIXER). Every chip uses the one T_KEY grey; teal for all is 0 B but vanishes on a muted MIXER card (part-colour fill), so it needs a contrast rule (bytes, and a look choice).
🤖 Generated with Claude Code