Fix: Use sce_stat->st_mode in io_to_posix_mode (glue.c) so it can also work for files stored in ISOs #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o work for files stored in ISOs
sharkwouter
approved these changes
Oct 23, 2024
|
Thanks for the PR. |
fjtrujy
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a PR as suggested by @sharkwouter
Key messages that led to this change which fixed my issue:
Initial issue explained: https://discord.com/channels/479828644970364928/668436284800237694/1298297311235145878
Testing
sceIoGetstatdirectly:https://discord.com/channels/479828644970364928/668436284800237694/1298625671383351296
and
https://discord.com/channels/479828644970364928/668436284800237694/1298651722356494378
Found a forum post which suggests that using
st_attrdoes not work when checking resources from a UMD, andst_modeshould be used instead:https://discord.com/channels/479828644970364928/668436284800237694/1298668881333846047
Issue is solved for me with this change from the PR, the SDL project works on both ISO and non-ISO context:
https://discord.com/channels/479828644970364928/668436284800237694/1298700049257201705