-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony 4 compat #80
Open
Jean85
wants to merge
35
commits into
psliwa:master
Choose a base branch
from
facile-it:symfony4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Symfony 4 compat #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change dir structure, use PSR-4 and src-tests splitting
Allow up to sensio/framework-extra-bundle v5
Require symfony components
Update PHPUnit
Update symfony
alexmanno
reviewed
May 16, 2019
Avoid using the deprecated kernel.root_dir param Co-Authored-By: Alessandro Manno <[email protected]>
Any progress on this one? :) |
I'm using this fork in production. It works, but I'm not using it thoroughly with all functionalities, so I can't vouch for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've worked on a fork of my own to make this bundle compatible with Symfony 4. This is a minimum-effort work, since I did not delve in the advanced features like dynamic image embedding, since I do not use them.
This PR merges all my fork, which consists in the Symfony 4 milestone:
src
/tests
dirssymfony/symfony
requirement with explicit components requirementssensio/framework-extra-bundle
5^2.3|^3.0
to^3.4|^4.0