Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple diagram and graphing infrastructure. #15

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zoalasaurusrawr
Copy link
Collaborator

  • Creates a simple AST of the state machine which should be full serializable to anything
  • Added a mermaid state diagram writer with support for signal type info

This is still very ugly, so opening as draft at first. I'll open it as a full PR once I get the rendering endpoint in place that integrates the diagram with a visualization JS lib

- Creates a simple AST of the state machine which should be full serializable to anything
- Added a mermaid state diagram writer with support for signal type info
Copy link
Contributor

@aidapsibr aidapsibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things I found:

Nested states/signals should be represented with DeclaringType.NestedType.FinalType name format
re-entrant states aren't displaying.

src/Liminality/GraphBuilder.cs Outdated Show resolved Hide resolved
src/Liminality/GraphBuilder.cs Outdated Show resolved Hide resolved
src/Liminality/GraphBuilder.cs Outdated Show resolved Hide resolved
src/Liminality/GraphBuilder.cs Outdated Show resolved Hide resolved
src/Liminality/GraphBuilder.cs Outdated Show resolved Hide resolved
src/Liminality/DiagramWriter.cs Outdated Show resolved Hide resolved
src/Liminality/DiagramWriter.cs Outdated Show resolved Hide resolved
src/Liminality/DiagramWriter.cs Outdated Show resolved Hide resolved
src/Liminality/DiagramWriter.cs Outdated Show resolved Hide resolved

namespace PSIBR.Liminality
{
public class VisualizationTests : IClassFixture<BasicStateMachineFixture>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things I found:

  • Nested states/signals should be represented with DeclaringType.NestedType.FinalType name format
  • re-entrant states arent displaying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants