Use QSet for reactions

psi-im · Jun 23, 2024 · 2b2265e · 2b2265e
1 parent 9009b34
commit 2b2265e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/xmpp/xmpp-im/types.cpp b/src/xmpp/xmpp-im/types.cpp
@@ -29,6 +29,8 @@
 #include <QList>
 #include <QMap>
 
+#include <optional>
+
 #define NS_XML "http://www.w3.org/XML/1998/namespace"
 
 namespace XMPP {
@@ -1810,9 +1812,10 @@ bool Message::fromStanza(const Stanza &s, bool useTimeZoneOffset, int timeZoneOf
             auto reactionTag = QStringLiteral("reaction");
             auto reaction    = reactionStanza.firstChildElement(reactionTag);
             while (!reaction.isNull()) {
-                d->reactions.reactions.append(reaction.text().trimmed());
+                d->reactions.reactions.insert(reaction.text().trimmed());
                 reaction = reaction.nextSiblingElement(reactionTag);
             }
+            d->reactions.reactions.squeeze();
         }
     }
 

diff --git a/src/xmpp/xmpp-im/xmpp_message.h b/src/xmpp/xmpp-im/xmpp_message.h
@@ -29,8 +29,7 @@
 #include "xmpp_url.h"
 
 #include <QExplicitlySharedDataPointer>
-
-#include <optional>
+#include <QSet>
 
 class QDateTime;
 class QString;
@@ -69,8 +68,8 @@ class Message {
     };
 
     struct Reactions {
-        QString     targetId;
-        QStringList reactions;
+        QString       targetId;
+        QSet<QString> reactions;
     };
 
     Message();