Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow str/bytes subclasses to be used as header parts #6356

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

sethmlarson
Copy link
Member

Closes #6159 Adapted from nateprewitt@66fcc9c but also supports mixed type tuples.

@nateprewitt
Copy link
Member

If you can rebase this onto the linting change, I think this is set.

@sethmlarson
Copy link
Member Author

@nateprewitt Done, ready for review!

Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sethmlarson sethmlarson merged commit 7f694b7 into psf:main Mar 3, 2023
@sethmlarson sethmlarson deleted the header-type-subclasses branch March 3, 2023 20:39
@nateprewitt nateprewitt mentioned this pull request Apr 25, 2023
jaypikay pushed a commit to jaypikay/doxy that referenced this pull request Apr 27, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [requests](https://requests.readthedocs.io) ([source](https://github.com/psf/requests), [changelog](https://github.com/psf/requests/blob/master/HISTORY.md)) | dependencies | minor | `2.28.2` -> `2.29.0` |

---

### Release Notes

<details>
<summary>psf/requests</summary>

### [`v2.29.0`](https://github.com/psf/requests/blob/HEAD/HISTORY.md#&#8203;2290-2023-04-26)

[Compare Source](psf/requests@v2.28.2...v2.29.0)

**Improvements**

-   Requests now defers chunked requests to the urllib3 implementation to improve
    standardization. ([#&#8203;6226](psf/requests#6226))
-   Requests relaxes header component requirements to support bytes/str subclasses. ([#&#8203;6356](psf/requests#6356))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42MS4wIiwidXBkYXRlZEluVmVyIjoiMzUuNjEuMCJ9-->

Co-authored-by: Renovate Bot <[email protected]>
Reviewed-on: https://git.goatpr0n.de/public/doxy/pulls/5
Co-authored-by: renovate <[email protected]>
Co-committed-by: renovate <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in 2.28.0 when using string enums as Headers (working in v2.27.1)
2 participants