Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert library to use playwright #574

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

cboin1996
Copy link

Pyppeteer is no longer maintained and playwright seems to be the way to go these days.

This merge request includes:

  1. CI runner in github to run the python tests
  2. Pipfile package updates
  3. Replacement of pyppeteer with playwright through source code

Users will be expected to run playwright install prior to running this library, and everything else just works like before.

@cboin1996
Copy link
Author

You can view the tests I ran here: cboin1996#1

@cboin1996 cboin1996 closed this Apr 16, 2024
@cboin1996 cboin1996 deleted the feat/convert-to-playwright branch April 16, 2024 18:04
@cboin1996 cboin1996 restored the feat/convert-to-playwright branch April 16, 2024 18:04
@cboin1996 cboin1996 reopened this Apr 16, 2024
@mspronesti
Copy link

Any updates on this PR from the maintainers?

@cboin1996
Copy link
Author

I havent heard anything. I have been using my own fork in the meantime.

pip install requests-htmlc

API docs: https://cboin1996.github.io/requests-html/latest/#getting-started

Quick start: https://github.com/cboin1996/requests-html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants