fix: compatibility with urllib3 2.0

[frostming]

Signed-off-by: Frost Ming [email protected]

Fix #292
Fix #293

[adiroiban]

Thanks @frostming for the change.

I see that besides the strict keyword removal this PR also does import reordering and some reformating and modernization changes.

---

Also for older urllib versions, this will just ignore the strict argument.

I think that we should wait for @ionrock to review this.

I was expecting to remove strict only for newer urllib versions, so that cachecontrol will continue to work with both old and new urllib versions.

[ionrock]

I agree with @adiroiban that we should avoid formatting changes. The caveat is unless black reformats something, in which case two commits might be helpful to communicate that is what is happening. I'd also skip the setup to setup_method as it isn't necessary.

I also think it is worthwhile to handle the earlier urllib versions. When I started looking at it, I had considered a function in compat.py that checked the version and would remove the strict field there based on the version.

Thanks for diving into this!

[miigotu]

Why not just set the minimum version of urllib supported by the next version, so that earlier urllib versions will just use the older cachecontrol? Trying to be backwards compatible with an obsolete package version seems unnecessary when a working version of cachecontrol already exists for those older versions. Sort of what versioning and pinning is for imo.

[frostming]

Why not just set the minimum version of urllib supported by the next version

I agree with this strategy. Requesting a library to support all possible Python versions and urllib3 versions is a pain for maintainers. Also we seem to have to drop Python 3.6 in the CI matrix. And eventually support for Python <3.7 should be dropped and compat.py isn't needed any more.

[adiroiban]

Good feedback.

Only supporting the latest urllib3 is a valid point, but then, this PR should update setup.py and declare this explicit dependency.

install_requires=["requests", "msgpack>=0.5.2"],

Thanks

[jacobg]

Hi, any status update on this one?

[frostming]

Hi, I have to move on to create a fork at https://github.com/frostming/cacheyou, with this issue addressed.

The long term plan is if this project can continue I will merge the changes back.

[dairiki]

I also think it is worthwhile to handle the earlier urllib versions. When I started looking at it, I had considered a function in compat.py that checked the version and would remove the strict field there based on the version.

Note that (when running under Python 3) urllib3==1.* simply discards and ignores any strict parameter passed to the HTTPConnection constructor. It has been this way since urllib3==1.8 (circa 2014, see urllib3/urllib3#343). (It is also noted in the urllib3 docs that that strict has no effect outside of Python 2.)

Since cachecontrol declares Requires-Python: >=3.6, it seems that it is pretty safe to simply remove the strict field.

[ETA: Also note that the strict parameter hasn't been supported by http.client.HTTPResponse since before Python 3.2.]

[ETA: IOW, the strict parameter, even where accepted, doesn't actually do anything under any extant version of Python 3. AFAICT, it can be safely ignored/dropped unless the intent is to support Python 2.]

[miigotu]

Hi, I have to move on to create a fork at https://github.com/frostming/cacheyou, with this issue addressed.

The long term plan is if this project can continue I will merge the changes back.

Thanks for that, I was close to doing the same thing but I'm glad someone stepped up for it. Sickchill is using your fork for the foreseeable future since cachecontrol hasn't been updated in years. I hope you can keep it relevant and set up a nice GitHub actions workflow to keep it always maintained and supporting the latest versions of everything. Godspeed.

[miigotu]

I also think it is worthwhile to handle the earlier urllib versions. When I started looking at it, I had considered a function in compat.py that checked the version and would remove the strict field there based on the version.

Note that (when running under Python 3) urllib3==1.* simply discards and ignores any strict parameter passed to the HTTPConnection constructor. It has been this way since urllib3==1.8 (circa 2014, see urllib3/urllib3#343). (It is also noted in the urllib3 docs that that strict has no effect outside of Python 2.)

Since cachecontrol declares Requires-Python: >=3.6, it seems that it is pretty safe to simply remove the strict field.

[ETA: Also note that the strict parameter hasn't been supported by http.client.HTTPResponse since before Python 3.2.]

[ETA: IOW, the strict parameter, even where accepted, doesn't actually do anything under any extant version of Python 3. AFAICT, it can be safely ignored/dropped unless the intent is to support Python 2.]

Just supporting the latest on python 3.8+ is ideal, backwards compatibility was a huge importance a few years ago before most projects finally got out of the python 2.7 trap. With GitHub actions and all the great tools now almost everyone has been able to keep their dependency trees updated thanks to dependabot. Older versions will just get the older cachecontrol with the pip dependency resolver so nobody misses anything to drop backwards compatible.

[frostming]

Closed in favor of #301, which provides a cleaner fix without format changes, thanks @dairiki .