Drop CI permissions, eliminate persisted credentials#4905
Merged
hauntsaninja merged 2 commits intopsf:mainfrom Dec 11, 2025
Merged
Drop CI permissions, eliminate persisted credentials#4905hauntsaninja merged 2 commits intopsf:mainfrom
hauntsaninja merged 2 commits intopsf:mainfrom
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
hauntsaninja
approved these changes
Dec 11, 2025
Collaborator
|
Thank you! |
This was referenced Dec 11, 2025
rxjacob
pushed a commit
to rxjacob/black
that referenced
this pull request
Jan 3, 2026
Signed-off-by: William Woodruff <william@yossarian.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This follows #4901 with some more CI security improvements. Namely:
actions/checkoutusage now includespersist-credentials: falseto avoid accidental credential persistence/leakage. Some exceptions to this that actually use the persisted credential (e.g. forgit push) havepersist-credentials: trueinstead with a comment, making explicit the implicit default.See zizmor's docs for more info on both of these:
Checklist - did you ...
--previewstyle, following thestability policy?
CHANGES.mdif necessary?Like with #4901, I believe none of the above apply since this is an internal-only change 🙂