Fix fmt:skip issues including some crashes#4822
Closed
Conversation
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
…f#4781) Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
JelleZijlstra
approved these changes
Nov 6, 2025
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
This was referenced Nov 21, 2025
Collaborator
Author
|
I split it up into multiple PRs so I can see where the issues are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix_fmt_skip_in_one_linerscrashing onwithstatements (fixes Crash with preview stylefix_fmt_skip_in_one_linersfor certain compound statements #4782)fix_fmt_skip_in_one_linerscrashing on annotated parameters (fixes Crash with preview stylefix_fmt_skip_in_one_linersfor function with annotated parameter and# fmt: skipon one line #4781)fmt: skipskipping the line after instead of the line it's on (fixes# fmt: skipignored in fluent interface #3364, fixes fmt: skip is required at the line which follows the one incorrectly formatted #4366)Checklist - did you ...
--previewstyle, following thestability policy?
CHANGES.mdif necessary?