-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add arm64 windows builds and tests #4814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d13b373
add arm64 windows to Tests
finnagin 7f70c43
add windows arm64 to release tests
finnagin fa88027
add windows arm64 wheel builds
finnagin 318fa2b
run on fork
finnagin 17e6de1
add windows arm64 to publish executables
finnagin c96ff7d
run on dispatch to test
finnagin 0e33e89
fix typo
finnagin 682bd1d
test in fork
finnagin 263b6ce
Update Python version to 3.13
finnagin d8b595d
use 3.12.10 for tests
finnagin 0a0179c
Add workflow_dispatch trigger to release test
finnagin 96b9ac3
Merge branch 'psf:main' into win-arm64
finnagin 60bd13d
run on all pushes to test
finnagin 4805f7d
uncomment release, remove extra workflow trigger
finnagin 4e11d81
uncomment paths
finnagin 8c7c0fa
remove fork branch trigger
finnagin c9aa5fd
Add arm64 windows note to CHANGES.md
finnagin 335a047
Merge branch 'main' into win-arm64
cobaltt7 dc73dbe
Merge branch 'main' into win-arm64
cobaltt7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,12 +13,16 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [windows-2025, ubuntu-22.04, ubuntu-22.04-arm, macos-latest] | ||
| os: [windows-2025, windows-11-arm, ubuntu-22.04, ubuntu-22.04-arm, macos-latest] | ||
| include: | ||
| - os: windows-2025 | ||
| pathsep: ";" | ||
| asset_name: black_windows.exe | ||
| executable_mime: "application/vnd.microsoft.portable-executable" | ||
| - os: windows-11-arm | ||
| pathsep: ";" | ||
| asset_name: black_windows-arm.exe | ||
| executable_mime: "application/vnd.microsoft.portable-executable" | ||
| - os: ubuntu-22.04 | ||
| pathsep: ":" | ||
| asset_name: black_linux | ||
|
|
@@ -38,7 +42,7 @@ jobs: | |
| - name: Set up latest Python | ||
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: "3.12.4" | ||
| python-version: "3.13" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed this from 3.12.4 -> 3.13 so that the setup-python action does not fail when installing on arm64 windows. I could also change this to a later version of 3.12 like I did in |
||
|
|
||
| - name: Install Black and PyInstaller | ||
| run: | | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bumped the 3.12 version from 3.12.4 to 3.12.10 here since the
setup-pythonaction fails to install 3.12.4 on arm64 windows and when I was looking back at the previous commit that set it to specify 3.12.4 it seemed to me it was to avoid an issue in 3.12.5 that was then fixed in 3.12.6.