Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with newer upload-artifact in PyPI action #4512

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

hauntsaninja
Copy link
Collaborator

Github is breaking older upload-artifact in a few weeks

Github is breaking older upload-artifact in a few weeks
@hauntsaninja hauntsaninja added the skip news Pull requests that don't need a changelog entry. label Nov 14, 2024
@JelleZijlstra JelleZijlstra merged commit f6c7c98 into psf:main Nov 14, 2024
46 of 47 checks passed
@hauntsaninja hauntsaninja deleted the pypi-up branch November 14, 2024 16:14
@webknjaz
Copy link

webknjaz commented Nov 18, 2024

@hauntsaninja any reason you didn't migrate to Trusted Publishing? It can produce digital attestations out of the box now: https://blog.pypi.org/posts/2024-11-14-pypi-now-supports-digital-attestations/.

(oh, for some reason I thought this was the MyPy repo)

@JelleZijlstra
Copy link
Collaborator

We should move to Trusted Publishing at some point, but that's a bit more work, so we'll do it when we do it I suppose. I'd probably accept a PR that does it for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants