Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4227: Black does not print errors with --quiet --check #4236

Merged
merged 10 commits into from
Mar 13, 2024

Conversation

dankrzeminski32
Copy link
Contributor

Description

This closes #4227

black was previously not printing any information when called with the --quiet and --check flags.

the related issue makes a valid point that black should stay quiet on successful runs and notify the user when changes are found.

I've omitted part of the output in an attempt to keep the output still quiet, but I can add it in if desired.

For example, when called without the --quiet flag:

would reformat ../test_black/test.py

Oh no! 💥 💔 💥
1 file would be reformatted.

When called with the --quiet flag:


Oh no! 💥 💔 💥
1 file would be reformatted.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@JelleZijlstra
Copy link
Collaborator

Thanks, but I think we don't need to change anything here (except perhaps the docs); see the issue.

@dankrzeminski32
Copy link
Contributor Author

@JelleZijlstra Sounds good, I can make a small doc adjustment in this PR or create a new PR if desired.

Copy link

diff-shades reports zero changes comparing this PR (2ac51f4) to main (d1d4fc5).


What is this? | Workflow run | diff-shades documentation

@JelleZijlstra
Copy link
Collaborator

Either works!

CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: Jelle Zijlstra <[email protected]>
@JelleZijlstra JelleZijlstra merged commit 719e674 into psf:main Mar 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black does not print errors with --quiet --check
2 participants