fix: Don't normalize whitespace before fmt:skip comments

[cobaltt7]

Description

Resolves #4143. I attempted to fix #2970 (review) while I was at it. However, that's a larger undertaking since _contains_fmt_skip_comment() requires a mode parameter and make_comment() doesn't - I'd have to add it to every caller of make_comment() and each of its callers, etc. Let me know if it's desired anyway.

Checklist - did you ...

• [y] Add an entry in CHANGES.md if necessary?
• [y] Add / update tests if necessary?
• [-] Add new / update outdated documentation?

[JelleZijlstra]

Thanks. This will have to go into the preview style as it changes existing formatting, and it'll probably have to wait until the 2024 stable style is out.

I don't understand the statement that you're not addressing https://github.com/psf/black/pull/2970#pullrequestreview-932691073—what else is there in that comment that this PR is not fixing?

[cobaltt7]

what else is there in that comment that this PR is not fixing?

#4143 talks about normalizing whitespace before the #. #2970 (review) is about whitespace immediately after the #. I thought I might as well just fix both, but like I said, the content after the # is formatted separately and would be harder to code.

This will have to go into the preview style as it changes existing formatting

Done!

[hauntsaninja]

This looks great, thank you!

(technically this change does meet the stability policy, since it won't cause changes in already blackened code, but always nice to let things bake in preview...)

[github-actions]

diff-shades reports zero changes comparing this PR (ffde332) to main (59b9d85).

---

What is this? | Workflow run | diff-shades documentation