Integrate verbose logging with get_sources #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the verbose logging for "Sources to be formatted" is a little suspect in that it is a completely different code path from `get_sources`. This can result in bugs like psf#3216 (comment) and generally limits the value of these logs. This does change the "when" of this log, but the colours help separate it from the even more verbose logs.
|
I'm also interested in this now because we spend a lot of time in |
src/black/__init__.py
Outdated
| @@ -653,7 +633,11 @@ def get_sources( | |||
| if is_stdin or p.is_file(): | |||
| normalized_path = normalize_path_maybe_ignore(p, ctx.obj["root"], report) | |||
There was a problem hiding this comment.
Seems like the mypyc build is broken here (see the diff-shades output in CI); it infers None for this variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the verbose logging for "Sources to be formatted" is a little suspect in that it is a completely different code path from
get_sources.This can result in bugs like #3216 (comment) and generally limits the value of these logs.
This does change the "when" of this log and splits it out across multiple lines, but the colours help separate it from the even more verbose logs.