-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with mypyc 1.3 #3697
Build with mypyc 1.3 #3697
Conversation
Thanks! I think we should jump straight to 1.3 if possible. |
8b8aeab
to
286d75b
Compare
Let's try 1.3, then! I'm not sure if any part of the mypyc release flow is really possible to test locally – from my understanding, that is only setup on CI? |
I believe it's testable by running |
Several new versions of mypyc has been released since the last upgrade, and they include some performance improvements which could make the compiled version of Black run faster. https://mypy-lang.org/news.html The latest version of hatch-mypyc allows being installed next the 1.x series of mypy.
286d75b
to
25eb12b
Compare
Great! Managed to follow those instructions and build at least a couple Linux wheels now and then test them inside a docker python image. I don't really have a rig for perf testing (only an old macbook, and building for mac required replacing my global python binary), but at the very least I managed to use my built version of black to reformat a tiny python file. Let me know if there's anything else I can do – either upload some of my built wheels, or specific tests that would be good to perform with them. |
Thanks, that sounds great! @ichard26 is our mypyc expert and he tagged himself, so I'll give him some time to add any feedback. |
It's been a month, let's merge this. |
Description
Several new versions of mypyc has been released since the last upgrade, and they include some performance improvements which could make the compiled version of Black run faster.
https://mypy-lang.org/news.html
The latest version of hatch-mypyc allows being installed next the 1.x series of mypy.
Checklist - did you ...
CHANGES.md
if necessary?