Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with mypyc 1.3 #3697

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Build with mypyc 1.3 #3697

merged 1 commit into from
Jun 23, 2023

Conversation

stianjensen
Copy link
Contributor

@stianjensen stianjensen commented May 19, 2023

Description

Several new versions of mypyc has been released since the last upgrade, and they include some performance improvements which could make the compiled version of Black run faster.

https://mypy-lang.org/news.html

The latest version of hatch-mypyc allows being installed next the 1.x series of mypy.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@ichard26 ichard26 self-requested a review May 19, 2023 21:04
@JelleZijlstra
Copy link
Collaborator

Thanks! I think we should jump straight to 1.3 if possible.

@stianjensen stianjensen changed the title Build with mypyc 1.2 Build with mypyc 1.3 May 19, 2023
@stianjensen
Copy link
Contributor Author

Let's try 1.3, then!

I'm not sure if any part of the mypyc release flow is really possible to test locally – from my understanding, that is only setup on CI?

@JelleZijlstra
Copy link
Collaborator

I believe it's testable by running cibuildwheel directly. This was discussed on our Discord (https://discord.com/channels/267624335836053506/846434317021741086/1096514507486023700).

Several new versions of mypyc has been released since the last upgrade, and they include some performance improvements which could make the compiled version of Black run faster.

https://mypy-lang.org/news.html

The latest version of hatch-mypyc allows being installed next the 1.x series of mypy.
@github-actions
Copy link

github-actions bot commented May 19, 2023

diff-shades reports zero changes comparing this PR (25eb12b) to main (eedfc38).


What is this? | Workflow run | diff-shades documentation

@stianjensen
Copy link
Contributor Author

I believe it's testable by running cibuildwheel directly.

Great! Managed to follow those instructions and build at least a couple Linux wheels now and then test them inside a docker python image. I don't really have a rig for perf testing (only an old macbook, and building for mac required replacing my global python binary), but at the very least I managed to use my built version of black to reformat a tiny python file.

Let me know if there's anything else I can do – either upload some of my built wheels, or specific tests that would be good to perform with them.

@JelleZijlstra
Copy link
Collaborator

Thanks, that sounds great! @ichard26 is our mypyc expert and he tagged himself, so I'll give him some time to add any feedback.

@JelleZijlstra
Copy link
Collaborator

It's been a month, let's merge this.

@JelleZijlstra JelleZijlstra merged commit c732a1f into psf:main Jun 23, 2023
@stianjensen stianjensen deleted the mypyc-upgrade-1.2 branch June 23, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants