Avoid EncodingWarning. Fixes #3695.

[jaraco]

Fixes #3695

[github-actions]

diff-shades reports zero changes comparing this PR (1c6d8c7) to main (2fd9d8b).

---

What is this? | Workflow run | diff-shades documentation

[cooperlees]

Makes sense to me, as we assume source we parse is UTF8 compatible ...

[JelleZijlstra]

I don't think we can assume Python source is UTF-8. However, seems like this is parsing the grammar files for blib2to3, which should be in UTF-8. I want to check the code some more, though.

[jaraco]

According to PEP 597 (motivation), UTF-8 is the default encoding on non-Windows systems, so by specifying it, you provide clarity and consistent behavior across platforms. You could specify encoding="locale", but I'd only recommend that if compatibility is essential and the variance is desirable. In my experience, it's almost always the case that using UTF-8 as the specified encoding provides the best experience and rarely leads to surprise. You should ask yourselves, do you expect that users have specifically put non-ascii non-UTF-8 characters in the grammar files and expect those to work only in that locale. If not, you probably want UTF-8. If so, you may want to migrate users away from that assumption.

[JelleZijlstra]

Users shouldn't put anything in the grammar files, we control all the grammar files and we don't support users providing their own. My hesitation is only about verifying that this codepath is purely about opening the internal grammar files, not user code.

[JelleZijlstra]

We only call this with our own files Grammar.txt and PatternGrammar.txt, which are ASCII.

[JelleZijlstra]

Thanks @jaraco!