Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing a more descriptive warning when reading a bad .gitignore #2433

Closed
wants to merge 1 commit into from

Conversation

john-science
Copy link

This is in response to the ticket: #2359

A particularly unhelpful error was thrown before, I feel this will be a lot more helpful to users trying to understand what went wrong.

@john-science
Copy link
Author

I tried different .gitignore errors and found a few possible things that can go wrong, so I grabbed all three error types.

I also converted the error to SyntaxError. This is the only questionable choice I think I made in this tiny PR. I think it makes it more clear to the user; it is a gitignore syntax problem, after all.

@JelleZijlstra
Copy link
Collaborator

#2414 is already open trying to improve the same area.

A particularly unhelpful error was thrown before, I feel this will
be a lot more helpful to users trying to understand what went wrong.
@ichard26
Copy link
Collaborator

Sorry @john-science but we've decided that #2414 is a better fit for resolving this issue mostly since it hides away all of the scary traceback and exception messaging and replaces it with a clear error message. Thanks for the contribution and effort tho!

@ichard26 ichard26 closed this Aug 20, 2021
@john-science
Copy link
Author

Sorry @john-science but we've decided that #2414 is a better fit...

No worries! Have a great weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants