Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid removing whitespace for parenthesized walrus in subscripts #4078

Closed
MichaReiser opened this issue Nov 29, 2023 · 1 comment · Fixed by #4109
Closed

Avoid removing whitespace for parenthesized walrus in subscripts #4078

MichaReiser opened this issue Nov 29, 2023 · 1 comment · Fixed by #4109
Labels
C: preview style Issues with the preview and unstable style. Add the name of the responsible feature in the title. S: accepted The changes in this design / enhancement issue have been accepted and can be implemented T: bug Something isn't working

Comments

@MichaReiser
Copy link

MichaReiser commented Nov 29, 2023 •
edited
Loading

Describe the bug

Related to the new walrus_subscript preview style and has previously been mentioned in this comment

Black removes whitespace around parenthesized walrus operators but preserves them for other binary operations:

x[(a + 4) :]
x[(a := 4):]

I would expect that the walrus operator gets formatted the same as any other binary operator:

x[(a := 4) :]

To Reproduce

See Playground
@MichaReiser MichaReiser added the T: bug Something isn't working label Nov 29, 2023
@MichaReiser MichaReiser mentioned this issue Nov 29, 2023
Closed
@JelleZijlstra JelleZijlstra added the C: preview style Issues with the preview and unstable style. Add the name of the responsible feature in the title. label Nov 29, 2023
@JelleZijlstra
Copy link
Collaborator

Agree we should change this.

@JelleZijlstra JelleZijlstra added the S: accepted The changes in this design / enhancement issue have been accepted and can be implemented label Nov 29, 2023
@cobaltt7 cobaltt7 mentioned this issue Dec 13, 2023
Merged
3 tasks
cobaltt7 added a commit to cobaltt7/black that referenced this issue Dec 14, 2023
@cobaltt7
Merge branch 'main' into psfgh-4078
e40c309
hauntsaninja pushed a commit that referenced this issue Dec 28, 2023
@cobaltt7
Treat walruses like other binary operators in subscripts (#4109)
c80685f 
Fixes #4078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: preview style Issues with the preview and unstable style. Add the name of the responsible feature in the title. S: accepted The changes in this design / enhancement issue have been accepted and can be implemented T: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: In subscripts, treat walruses just like other binary operators cobaltt7/black
2 participants
@JelleZijlstra @MichaReiser